-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically scale the default memory allocation #6900
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 37.11% 37.15% +0.03%
==========================================
Files 144 144
Lines 8955 8979 +24
==========================================
+ Hits 3324 3336 +12
- Misses 5212 5220 +8
- Partials 419 423 +4
|
All Times minikube: [ 93.192010 92.873971 90.675578] Average minikube: 92.247186 Averages Time Per Log
|
All Times minikube: [ 92.365465 92.052297 93.063564] Average minikube: 92.493776 Averages Time Per Log
|
tried it locally with my mac looks good
|
Did you feedback this to https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/
Or is the problem that it needs 2Gi free - just for Kubernetes, rather than 2Gi total ? The wording of "per machine" is a little ambiguous. Elsewhere it says "per node" |
If it's KIC, allow minikube to grow up until the containers maximum footprint, minus 128MB. This safety margin is to avoid unexpected results if someone else has a small docker image running.
If it's a VM, allocate 25% of the available memory, up to 6GB. Never allocate less than 2.2GB by default. This balances the safety of a well-configured VM up-front, and the ability to run multiple local clusters.
Specifically allocate memory ranges for most integration tests, so that they can coexist in parallel on a single machine.
Fixes #5021