add buildroot based minikube-iso build infrastructure #692
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Can one of the admins verify this patch? |
|
Note that I included the history from the old project, so I assume, that quite some CLAs are missing. |
Current coverage is 31.59% (diff: 100%)@@ master #692 diff @@
==========================================
Files 42 42
Lines 1918 1918
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 606 606
Misses 1185 1185
Partials 127 127
|
|
@minikube-bot ok to test |
|
@minikube-bot add to whitelist |
|
Thanks! It looks like the cla bot is complaining that you (@s-urbaniak) need to sign, and it also says "4 other problems). Not sure how to find out what those are... |
|
@dlorenc my commits are sur@coreos.com which implicitely has CLA signed. But the minikube-iso surely had some contributors which may have not signed it. If you want, I can squash the complete history, the only downside would be, that we would lose it. |
|
I think that would go against the point of the checks, we'll have to reach out to the authors and get them to sign. Any idea why it thinks you haven't signed yet though? I had to register my email even though I've implicitly signed through my employer. |
|
I went through the history, and some commits from me use the email sergiusz.urbaniak@gmail.com, let me fix that. I hope that at least for me the CLA goes away. |
… path Local build no longer required after the Minikube v0.10 release
- xhyve driver now supports the use of QEMU qcow2 disk image to a virtual disk. It mounts on top of the virtio-blk, we need to enable it. Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
To easily find out which kernel options are enabled.
s-urbaniak
force-pushed
the
minikube-iso
branch
from
4f817d7
to
528dd36
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@iaguis @ryanj Can I kindly ask you to sign the CLA with the email addresses iago@kinvolk.io, and ryan.jarvinen@gmail.com |
|
cc @ethernetdan |
|
I signed the CLA as a corporation under Kinvolk GmbH: |
|
I couldn't figure out how to sign the latest corporate CLA form, and I didn't want to block this issue, so I signed as an individual contributor (short term). |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
In mine it says:
😕 |
@iaguis I did some digging and it looks like the issue is that the CLA bot can't confirm that you are the same person that authored the commit. Do you have both email addresses added to your github account? It looks like this error is OK for us to override if we've manually verified that you've given consent, so if we can't figure it out we can still move forward :) |
|
|
||
| ### Testing local minikube-iso changes | ||
|
|
||
| To test a local build of minikube-iso, start a web server (i.e. Caddy) to serve the ISO image, and start `minikube` with an `--iso-url` pointing to localhost: |
There was a problem hiding this comment.
ISO URL can accept a file:// URL iirc
|
Hmm, this still says @s-urbaniak needs a CLA. Any idea what's up? |
|
Sorry, I don't really have clue :-( Maybe the bot is overwhelmed, because I took over the whole history. Since all parties agreed on the CLA, can we somehow merge it manually? I'd address #692 (comment) in a separate PR. |
|
@minikube-bot test this please |
|
Yeah, I'll kick off one more round of tests (something seems up there) then merge. |
|
@minikube-bot test this please |
|
Merging. The xhyve failure is a test infra issue. |
This moves all files from https://github.com/coreos/minikube-iso to minikube itself.
One can build the minikub-iso image directly from the top-level directory using
Partially fixes #571