-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preload: fix bug for windows file separators #6968
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6968 +/- ##
==========================================
- Coverage 37% 36.99% -0.01%
==========================================
Files 144 144
Lines 9013 9015 +2
==========================================
Hits 3335 3335
- Misses 5256 5258 +2
Partials 422 422
|
/ok-to-test |
Error: running mkcmp: exit status 1 |
All Times minikube: [ 61.485357 62.234412 63.378993] Average minikube: 62.366254 Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
should fix #6944