Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning if disk image is missing features #6978

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Add warning if disk image is missing features #6978

merged 1 commit into from
Mar 10, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 10, 2020 •
edited
Loading

UI when upgrading a v1.6 ISO:

⌛  Reconfiguring existing host ...
🏃  Using the running hyperkit "minikube" VM ...
💡  Existing disk is missing new features (lz4). To upgrade, run 'minikube delete'
🐳  Preparing Kubernetes v1.17.3 on Docker 19.03.5 ...

Related: #6938

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2020
@tstromberg tstromberg requested a review from medyagh March 10, 2020 14:41
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 10, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 63.653543 65.686681 67.125953]
All Times Minikube (PR 6978): [ 65.998079 66.310413 66.123304]

Average minikube: 65.488726
Average Minikube (PR 6978): 66.143932

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6978) |
+----------------------+-----------+--------------------+
| minikube v           |  0.228313 |           0.214690 |
| Creating kvm2        | 41.118138 |          41.239945 |
| Preparing Kubernetes |  0.757440 |           0.815962 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.279016 |          20.548468 |
| Waiting for cluster  |  0.058215 |           0.229616 |
+----------------------+-----------+--------------------+

@medyagh medyagh merged commit caf44e2 into kubernetes:master Mar 10, 2020
@afbjorklund afbjorklund mentioned this pull request Mar 10, 2020
Closed
@fmotrifork fmotrifork mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tstromberg @k8s-ci-robot @minikube-pr-bot @sharifelgamal @medyagh