Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement options for the minikube version command #7325

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

afbjorklund
Copy link
Collaborator

Add --short and --output options, just like kubectl

Closes #7322

Add --short and --output options, just like kubectl
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the output?

@afbjorklund
Copy link
Collaborator Author

Could you please add the output?

#7322 (comment)

@medyagh
Copy link
Member

medyagh commented Mar 31, 2020

there is a lint issue

@afbjorklund
Copy link
Collaborator Author

Thanks for adding the missing newline

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 1, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 61.829663 63.762791 64.750639]
All Times Minikube (PR 7325): [ 63.438020 64.985951 63.102519]

Average minikube: 63.447698
Average Minikube (PR 7325): 63.842163

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7325) |
+----------------------+-----------+--------------------+
| minikube v           |  0.215764 |           0.218107 |
| Creating kvm2        | 40.015975 |          40.552678 |
| Preparing Kubernetes | 21.378299 |          21.161766 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 428e6bd into kubernetes:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten minikube version output
5 participants