Use kubectl version --short if --output=json fails #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really old kubernetes clients did not have the --output parameter Show a friendly reminder to upgrade, instead of an error message.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #7356 +/- ##
==========================================
- Coverage 37.16% 37.12% -0.04%
==========================================
Files 145 145
Lines 8762 8771 +9
==========================================
Hits 3256 3256
- Misses 5110 5119 +9
Partials 396 396
|
medyagh
approved these changes
Apr 1, 2020
medyagh
reviewed
Apr 1, 2020
| func kubectlVersion(path string) (string, error) { | ||
| j, err := exec.Command(path, "version", "--client", "--output=json").Output() | ||
| if err != nil { | ||
| // really old kubernetes clients did not have the --output parameter |
There was a problem hiding this comment.
just a nit, wouldn't hurt to info log the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really old kubernetes clients did not have the --output parameter
Show a friendly reminder to upgrade, instead of an error message.
Closes #7350