-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallelize updating cluster and setting up certs #7394
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, there are few more of these we could do in following up PRs. lets analyse the test results on jenkins
/ok-to-test |
Error: running mkcmp: exit status 1 |
The following Docker Driver Failures TestStartStop/group/containerd - 251.5s--- needs to verified that is not related to this PR (havne't looked): TestStartStop/group/crio - 759.66sTestStartStop/group/embed-certs - 144.29sTestFunctional/parallel/ComponentHealth |
This seems good. Looking at SlowJam, If we parallelized the Here's a bigger idea, that should result in shaving >5s off of the Docker runtime:
If you compare the slowjam profiles of hyperkit versus docker, you can see the benefit: SetupCerts:
Rough napkin math: Each command or copy on Docker costs at least 0.1 seconds. On ssh it doesn't even show up in the SlowJam graph. I reckon we execute and copy ~60 commands. Thus, I think we should be able to expect 5s in time savings. |
Reduces time in setupKubeadm function from 4.6s to 3.2s
slowjam before change: http://104.197.255.167:8000
slowjam after change: http://34.67.230.103:8000