Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "sudo" to podman calls #7631

Merged
merged 28 commits into from
Apr 29, 2020
Merged

Add "sudo" to podman calls #7631

merged 28 commits into from
Apr 29, 2020

Commits on Apr 19, 2020

  1. The podman driver should not be run as root 

    Use sudo for the podman commands instead

Wrap the docker commands with env prefix
    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    d7dc7bf View commit details
    Browse the repository at this point in the history

  2. Remove extra single-quotes from format parameter 

    podman
	Error: template parsing error: template: image:1: function "json" not defined
    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    f264ac1 View commit details
    Browse the repository at this point in the history

  3. Don't download podman images to docker daemon

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    401e94c View commit details
    Browse the repository at this point in the history

  4. Handle more state and status for the podman driver

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    22aa1af View commit details
    Browse the repository at this point in the history

  5. Only remount the /var/lib/minikube directory

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    f57faf8 View commit details
    Browse the repository at this point in the history

  6. Missed to wrap one podman inspect in sudo proper

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    df3aec6 View commit details
    Browse the repository at this point in the history

  7. Also create and mount the container runtime dirs

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    2234246 View commit details
    Browse the repository at this point in the history

  8. Also persist the kubelet and the cni state dirs

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    8987b10 View commit details
    Browse the repository at this point in the history

  9. Fix hack binary, as pointed out by golangci-lint

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    45ec38d View commit details
    Browse the repository at this point in the history

  10. Use the same kind of named /var mount for podman 

    The internal anonymous mounts do not seem to have the same
issues as the external path mounts, so we can do all of /var
    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    024cd6b View commit details
    Browse the repository at this point in the history

  11. Resource limits seem to work ok when not rootless

    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    19be561 View commit details
    Browse the repository at this point in the history

  12. Improve podman status when checking for sudo 

    Only use sudo for info and running on linux
    @afbjorklund
    afbjorklund committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    e99340b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2020

  1. Merge branch 'master' into podman-sudo

    @afbjorklund
    afbjorklund committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    6644c5c View commit details
    Browse the repository at this point in the history

  2. Fix log message to say driver and not cruntime

    @afbjorklund
    afbjorklund committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    bb37c70 View commit details
    Browse the repository at this point in the history

  3. Don't try to limit podman memory without cgroup 

    Podman requires both memcg and memcg_swap for it (--memory).

Docker will still limit memory, without swap limit support.
    @afbjorklund
    afbjorklund committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    7647b1f View commit details
    Browse the repository at this point in the history

  4. Remove extra quotes added in conflict resolution 

    Reverted f264ac1 by accident
    @afbjorklund
    afbjorklund committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    7185140 View commit details
    Browse the repository at this point in the history

  5. Pass the container implementation on to systemd

    @afbjorklund
    afbjorklund committed Apr 25, 2020
    Configuration menu
    Copy the full SHA
    88c8a24 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. Include any output from podman version in the log

    @afbjorklund
    afbjorklund committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    d96d9d3 View commit details
    Browse the repository at this point in the history

  2. Use constants instead of the KIC prefix strings

    @afbjorklund
    afbjorklund committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    28106fa View commit details
    Browse the repository at this point in the history

  3. Fix copy/paste error on the podman usage page

    @afbjorklund
    afbjorklund committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    e95ae32 View commit details
    Browse the repository at this point in the history

  4. Remove old Copy function added in merge conflict

    @afbjorklund
    afbjorklund committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    7951281 View commit details
    Browse the repository at this point in the history

  5. Use simple version of podman info format parameter 

    So that it works with the older versions of podman
    @afbjorklund
    afbjorklund committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    998ab84 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Align podman driver with docker and improve check 

    Make sure to use "sudo podman version" on Linux
(need user namespace support for "podman version")

And improve error output handling for podman-remote
(when the remote service is not running properly)
    @afbjorklund
    afbjorklund committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    95c9559 View commit details
    Browse the repository at this point in the history

  2. Podman allows setting --cpus and --memory now

    @afbjorklund
    afbjorklund committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    a041f40 View commit details
    Browse the repository at this point in the history

  3. Log the version used of the two KIC runtimes

    @afbjorklund
    afbjorklund committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    bf4aa78 View commit details
    Browse the repository at this point in the history

  4. Restore the configured state added for podman 

    Reverted 22aa1af by accident
    @afbjorklund
    afbjorklund committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    1744ffe View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Merge branch 'master' into podman-sudo

    @afbjorklund
    afbjorklund committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    f78e00e View commit details
    Browse the repository at this point in the history

  2. Remove prefix parameter and add prefix command 

    Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
    @afbjorklund
    afbjorklund committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    78a22f5 View commit details
    Browse the repository at this point in the history