Podman bugs #7640
Podman bugs #7640
Conversation
podman Error: template parsing error: template: image:1: function "json" not defined
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
afbjorklund
force-pushed
the
podman-bugs
branch
from
7837cfa
to
8aaa7be
Compare
|
Hmm, wonder why the "unable to find" didn't work |
| return image.WriteImageToDaemon(kic.BaseImage) | ||
| }) | ||
| glog.Infof("Beginning downloading kic artifacts for %s with %s", driver, cRuntime) | ||
| if driver == "docker" { |
There was a problem hiding this comment.
shouldnt this be driver.IsKIC( ?
There was a problem hiding this comment.
It is driver.IsKIC (in the caller), but this function calls the docker-specific WriteImageToDaemon
There was a problem hiding this comment.
Let's use oci.Docker not string
There was a problem hiding this comment.
oci.Docker is a string, but ok. Would be nice to have something generic, in image ? Preferrably with a progressbar.
afbjorklund
force-pushed
the
podman-bugs
branch
from
8aaa7be
to
16aef24
Compare
|
So we just skip the cache, and let the |
|
Note that there is no daemon for local podman, only for remote podman (varlink socket). So this does not make so much sense either: Maybe that should be Also still wonder why this is called "OCI", but I guess it has to be called something. i.e. this is mostly about the docker cli, and not so much about opencontainers.org the standard is mostly about But I'm not about to change any of that, I just want it to be running (similar to docker) |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
| return image.WriteImageToDaemon(kic.BaseImage) | ||
| }) | ||
| glog.Infof("Beginning downloading kic artifacts for %s with %s", driver, cRuntime) | ||
| if driver == "docker" { |
There was a problem hiding this comment.
Let's use oci.Docker not string
| }) | ||
| } | ||
| // TODO: driver == "podman" | ||
| glog.Info("Container runtime isn't docker, skipping download") |
There was a problem hiding this comment.
Did you mean the driver is not docker ?
There was a problem hiding this comment.
Well, the driver also has a container runtime. Which is of course confusing.
We download kicbase for the outer runtime, and kubernetes for the inner...
But the commands and messages are the same for both of the runtimes.
| @@ -99,13 +99,17 @@ func doCacheBinaries(k8sVersion string) error { | |||
| } | |||
|
|
|||
| // BeginDownloadKicArtifacts downloads the kic image + preload tarball, returns true if preload is available | |||
| func beginDownloadKicArtifacts(g *errgroup.Group) { | |||
There was a problem hiding this comment.
I thought it would be, but we don't use the preload hack for the kicbase image
|
On the oci naming it was hard to find any name that wasn't wrong. I looked up Wikipedia on both docker and podman and I saw what they had in common is they are both considered oci implementation. By oci I meant anytime we have to talk to docker cli or podman cli outside the minikube node ( on th user's host machine and not using ssh runner or kic runner) But I admit I wish there was a better less confusing name. |
|
I think most of this branch/PR will end up getting merged into #7631 instead. |
Here are some of the various podman driver bugs that I found, when trying to fix #7631
It seems like we have docker hardcoded in a lot of places, and that podman is untested.