docker driver: Add Service & Tunnel features to windows #7739

medyagh · 2020-04-17T06:44:43Z

we totally forgot to Enable the tunnel and service on windows .
I personally tried this PR on a windows machine and it works

special thanks to our user @ps-feng for brining this to my attention
#7644

and the biggest thanks to one of the minikube heros @josedonizetti for implementing this feature.

k8s-ci-robot · 2020-04-17T06:45:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2020-04-17T06:46:06Z

/ok-to-test

codecov-io · 2020-04-17T06:54:03Z

Codecov Report

Merging #7739 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #7739   +/-   ##
=======================================
  Coverage   36.22%   36.22%           
=======================================
  Files         148      148           
  Lines        9217     9217           
=======================================
  Hits         3339     3339           
  Misses       5488     5488           
  Partials      390      390

Impacted Files	Coverage Δ
cmd/minikube/cmd/service.go	`10.44% <0.00%> (ø)`
cmd/minikube/cmd/tunnel.go	`5.12% <0.00%> (ø)`

minikube-pr-bot · 2020-04-17T07:08:14Z

kvm2 Driver
Times for minikube: [63.237295272000004 63.528750298 64.04635255]
Average time for minikube: 63.60413270666667

Times for Minikube (PR 7739): [64.223400357 64.447323429 64.88748526799999]
Average time for Minikube (PR 7739): 64.519403018

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7739) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.057164 |           0.054380 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019604 |           0.019714 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.005823 |           0.003192 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.488570 |          40.968587 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.005535 |          21.301225 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.955711 |           2.092581 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.068855 |           0.076002 |
| configured to use "minikube"   |           |                    |
|                                |  0.002872 |           0.003722 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [23.854752568000002 27.976733516000003 24.857466590000005]
Average time for minikube: 25.562984224666668

Times for Minikube (PR 7739): [25.478878437 27.137865107000003 24.804457299000003]
Average time for Minikube (PR 7739): 25.80706694766667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7739) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.069877 |           0.067939 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002120 |           0.002455 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.053286 |           0.055027 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.341655 |           7.234981 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000157 |           0.000167 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.906991 |          16.924666 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.126465 |           1.456683 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.058373 |           0.060608 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004059 |           0.004542 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-17T07:48:04Z

kvm2 Driver
Times for minikube: [66.425964277 62.671668954999994 64.346337818]
Average time for minikube: 64.48132368333334

Times for Minikube (PR 7739): [63.31024508500001 66.132260105 63.45019617]
Average time for Minikube (PR 7739): 64.29756712

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7739) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.058195 |           0.056105 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.017756 |           0.019102 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.008660 |           0.003153 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.985750 |          40.443725 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.834628 |          21.398269 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.504671 |           2.293236 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.069018 |           0.080458 |
| configured to use "minikube"   |           |                    |
|                                |  0.002645 |           0.003519 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.056240637000005 25.138958246000005 26.593967083]
Average time for minikube: 26.263055322

Times for Minikube (PR 7739): [23.628040347000002 25.881277017 23.695240406]
Average time for Minikube (PR 7739): 24.401519256666663

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7739) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.071052 |           0.068334 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002288 |           0.003468 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.053935 |           0.054118 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.184592 |           7.105964 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000184 |           0.000165 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.484749 |          16.104955 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.402383 |           0.997443 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.059405 |           0.063241 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004467 |           0.003833 |
+----------------------------------------+-----------+--------------------+

cowwoc · 2020-09-05T03:39:23Z

What version did this end up getting released as?

mail4kjr · 2022-04-06T16:43:19Z

do the port and it will work.
kubectl port-forward service/hello-minikube 7080:8080
kubectl port-forward service/hello-minikube 7080:

enable tunnel and service for docker on windows

2a38fa3

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2020

k8s-ci-robot requested review from afbjorklund and josedonizetti April 17, 2020 06:45

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 17, 2020

kubernetes deleted a comment from minikube-pr-bot Apr 17, 2020

medyagh mentioned this pull request Apr 17, 2020

minikube service not working with Docker driver on Windows 10 Pro #7644

Closed

fix message

27bd2a9

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2020

medyagh changed the title ~~enable tunnel and service for docker on windows~~ Add Service and Tunnel features to windows Apr 17, 2020

medyagh changed the title ~~Add Service and Tunnel features to windows~~ Add Service & Tunnel features to windows Apr 17, 2020

medyagh changed the title ~~Add Service & Tunnel features to windows~~ docker driver: Add Service & Tunnel features to windows Apr 17, 2020

sharifelgamal approved these changes Apr 17, 2020

View reviewed changes

medyagh merged commit 4c887bb into kubernetes:master Apr 17, 2020

medyagh deleted the windows_servicePort branch May 2, 2020 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docker driver: Add Service & Tunnel features to windows #7739

docker driver: Add Service & Tunnel features to windows #7739

medyagh commented Apr 17, 2020 •

edited

Loading

k8s-ci-robot commented Apr 17, 2020

medyagh commented Apr 17, 2020

codecov-io commented Apr 17, 2020 •

edited

Loading

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

cowwoc commented Sep 5, 2020

mail4kjr commented Apr 6, 2022

docker driver: Add Service & Tunnel features to windows #7739

docker driver: Add Service & Tunnel features to windows #7739

Conversation

medyagh commented Apr 17, 2020 • edited Loading

k8s-ci-robot commented Apr 17, 2020

medyagh commented Apr 17, 2020

codecov-io commented Apr 17, 2020 • edited Loading

Codecov Report

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

cowwoc commented Sep 5, 2020

mail4kjr commented Apr 6, 2022

medyagh commented Apr 17, 2020 •

edited

Loading

codecov-io commented Apr 17, 2020 •

edited

Loading