Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dashboard image v2.0.0 #7849

Merged
merged 1 commit into from
Apr 24, 2020
Merged

bump dashboard image v2.0.0 #7849

merged 1 commit into from
Apr 24, 2020

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Apr 22, 2020

What type of PR is this?

/kind feature
/area addons

What this PR does / why we need it:

This PR bump up the dashboard addon image to v2.0.0.
I know it's needed to upload preload tarball to GCS.
But I don't have permission to upload it.
Can anyone who can upload support?

Which issue(s) this PR fixes:

Fixes #7847

Does this PR introduce a user-facing change?

Yes. This PR change dashboard's image.
Before: kubernetesui/dashboard:v2.0.0-rc6
After: kubernetesui/dashboard:v2.0.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@govargo govargo added co/dashboard dashboard related issues and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2020
@govargo
Copy link
Contributor Author

govargo commented Apr 22, 2020

/assign @priyawadhwa

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@TravisBuddy
Copy link

Travis tests have failed

Hey @govargo,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e116e2c0-84b2-11ea-aa8b-a3fb45836a64

@govargo
Copy link
Contributor Author

govargo commented Apr 22, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@govargo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@govargo
Copy link
Contributor Author

govargo commented Apr 22, 2020

Unit test fail...but I think this is not directly related to.
I hope retest this

panic: Fail in goroutine after TestCreateSSHShell has completed
goroutine 242 [running]:
testing.(*common).Fail(0xc0008f5e00)
	/home/travis/.gimme/versions/go1.13.8.linux.amd64/src/testing/testing.go:609 +0x151
testing.(*common).Errorf(0xc0008f5e00, 0x13574e3, 0x16, 0xc00042bf00, 0x1, 0x1)
	/home/travis/.gimme/versions/go1.13.8.linux.amd64/src/testing/testing.go:704 +0x90
k8s.io/minikube/pkg/minikube/tests.(*SSHServer).handleRequest(0xc0000c5680, 0x165a780, 0xc000176d80, 0xc0002eefc0)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/tests/ssh_mock.go:154 +0x573
k8s.io/minikube/pkg/minikube/tests.(*SSHServer).handleIncomingConnection(0xc0000c5680, 0x165f6a0, 0xc000010268)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/tests/ssh_mock.go:118 +0x15f
created by k8s.io/minikube/pkg/minikube/tests.(*SSHServer).serve
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/tests/ssh_mock.go:92 +0x4a
FAIL	k8s.io/minikube/pkg/minikube/machine	3.266s

@priyawadhwa
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2020
@priyawadhwa
Copy link

Hey @govargo that unit test is flaky -- otherwise everything looks good!

@priyawadhwa priyawadhwa changed the title bumup dashboard image v2.0.0 bump dashboard image v2.0.0 Apr 22, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 22, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@medyagh
Copy link
Member

medyagh commented Apr 22, 2020

@priyawadhwa this is a good example of the issue this PR was trying to investigate
#7804

right now with this PR, I think with our generated preload tarball, it will invoke a reset and re-pull because the dasbboard is not same verison
we could refactor our preload, DockerImagesPreloaded from Bool to a []string
that would return list of images that need to be pulled again. what do u think ?

@govargo
Copy link
Contributor Author

govargo commented Apr 23, 2020

I rebased latest master. The flake test doesn't appear this time(unit test success).

@codecov-io
Copy link

Codecov Report

Merging #7849 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7849   +/-   ##
=======================================
  Coverage   35.60%   35.60%           
=======================================
  Files         148      148           
  Lines        9305     9305           
=======================================
  Hits         3313     3313           
  Misses       5595     5595           
  Partials      397      397           
Impacted Files Coverage Δ
pkg/minikube/download/preload.go 0.00% <ø> (ø)
pkg/minikube/bootstrapper/images/images.go 87.50% <100.00%> (ø)

@medyagh medyagh merged commit 3342acb into kubernetes:master Apr 24, 2020
@govargo govargo deleted the update-dashboard-2.0.0 branch February 13, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. co/dashboard dashboard related issues kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump kubernetesui/dashboard:v2.0.0
8 participants