-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump dashboard image v2.0.0 #7849
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: govargo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @priyawadhwa |
Can one of the admins verify this patch? |
Travis tests have failedHey @govargo, TravisBuddy Request Identifier: e116e2c0-84b2-11ea-aa8b-a3fb45836a64 |
/retest |
@govargo: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Unit test fail...but I think this is not directly related to.
|
/ok-to-test |
Hey @govargo that unit test is flaky -- otherwise everything looks good! |
kvm2 Driver |
@priyawadhwa this is a good example of the issue this PR was trying to investigate right now with this PR, I think with our generated preload tarball, it will invoke a reset and re-pull because the dasbboard is not same verison |
I rebased latest master. The flake test doesn't appear this time(unit test success). |
Codecov Report
@@ Coverage Diff @@
## master #7849 +/- ##
=======================================
Coverage 35.60% 35.60%
=======================================
Files 148 148
Lines 9305 9305
=======================================
Hits 3313 3313
Misses 5595 5595
Partials 397 397
|
What type of PR is this?
/kind feature
/area addons
What this PR does / why we need it:
This PR bump up the dashboard addon image to v2.0.0.
I know it's needed to upload preload tarball to GCS.
But I don't have permission to upload it.
Can anyone who can upload support?
Which issue(s) this PR fixes:
Fixes #7847
Does this PR introduce a user-facing change?
Yes. This PR change dashboard's image.
Before:
kubernetesui/dashboard:v2.0.0-rc6
After:
kubernetesui/dashboard:v2.0.0
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: