Wait to add aliases to /etc/hosts before starting kubelet #8035

priyawadhwa · 2020-05-07T20:04:05Z

kubelet manages the value of /etc/hosts within running containers (e.g. kube-controller-manager). It takes this file from the host, but this causes a race condition between:

Us updating /etc/hosts with aliases on IP changes
kubelet starting k8s with current value of /etc/hosts

This change removes automatically starting kubelet when systemd comes up. Instead, we start it immediately after making our updates to /etc/hosts

This should fix the embed-certs integration test which has been flaky for a while.

Fixes #7921

This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different. This should fix the embed-certs integration test which has been flaky for a while.

priyawadhwa · 2020-05-07T20:04:12Z

/ok-to-test

k8s-ci-robot · 2020-05-07T20:04:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/drivers/kic/kic.go

minikube-pr-bot · 2020-05-07T20:14:21Z

kvm2 Driver
docker Driver

minikube-pr-bot · 2020-05-07T20:33:49Z

kvm2 Driver
Times for minikube: [61.398031624 61.862575105 66.21038982000002]
Average time for minikube: 63.15699884966666

Times for Minikube (PR 8035): [60.127947904 63.15791365100001 63.32869082100001]
Average time for Minikube (PR 8035): 62.204850792

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8035) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.056468 |           0.059320 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020921 |           0.020390 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003229 |           0.002868 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.799665 |          38.473730 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 21.238712 |          21.411683 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.316622 |           1.470164 |
| components...                  |           |                    |
| * Enabled addons:              |  0.629425 |           0.678372 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.088660 |           0.082474 |
| configured to use "minikube"   |           |                    |
|                                |  0.003297 |           0.005851 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.58188183 26.853225248999994 26.805388235000002]
Average time for minikube: 26.413498438

Times for Minikube (PR 8035): [26.975172612999998 25.718133115 28.078879105]
Average time for Minikube (PR 8035): 26.924061611

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8035) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.072329 |           0.077415 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002665 |           0.002536 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.061040 |           0.057179 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.590438 |           7.493291 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.116059 |           0.120275 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.132892 |          17.637064 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.367652 |           1.461946 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002461 |           0.002520 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062752 |           0.064864 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005210 |           0.006973 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-05-07T20:53:30Z

kvm2 Driver
Times for minikube: [63.579671891 62.58763652500001 63.965156715000006]
Average time for minikube: 63.377488377

Times for Minikube (PR 8035): [63.581135766 64.297740915 64.432486893]
Average time for Minikube (PR 8035): 64.10378785799999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8035) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.060783 |           0.061603 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.019836 |           0.021259 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003223 |           0.005029 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.060477 |          40.593988 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 21.143890 |          21.542535 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.624877 |           1.246247 |
| components...                  |           |                    |
| * Enabled addons:              |  0.394720 |           0.553912 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.066580 |           0.072709 |
| configured to use "minikube"   |           |                    |
|                                |  0.003102 |           0.006507 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.044882525000002 26.471795668 28.011532360999997]
Average time for minikube: 27.176070184666667

Times for Minikube (PR 8035): [27.951298372 27.972385985999995 26.881018652]
Average time for Minikube (PR 8035): 27.601567670000005

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8035) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.073708 |           0.076578 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002411 |           0.002298 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.060664 |           0.057917 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.697533 |           7.577018 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.145762 |           0.121456 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.878136 |          18.541864 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.182407 |           0.860263 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.067033 |           0.294218 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.064400 |           0.064162 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004017 |           0.005793 |
+----------------------------------------+-----------+--------------------+

codecov-io · 2020-05-07T20:56:52Z

Codecov Report

Merging #8035 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8035   +/-   ##
=======================================
  Coverage   35.76%   35.77%           
=======================================
  Files         143      143           
  Lines        9191     9189    -2     
=======================================
  Hits         3287     3287           
+ Misses       5504     5502    -2     
  Partials      400      400

Impacted Files	Coverage Δ
pkg/minikube/cluster/pause.go	`0.00% <ø> (ø)`

minikube-pr-bot · 2020-05-07T21:33:17Z

kvm2 Driver
Times for minikube: [64.349314058 63.98612218000001 67.281269981]
Average time for minikube: 65.20556873966667

Times for Minikube (PR 8035): [64.03327127200001 61.350225456 67.491866983]
Average time for Minikube (PR 8035): 64.29178790366666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8035) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.061940 |           0.057845 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.021237 |           0.019168 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003060 |           0.002886 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.632192 |          40.214572 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.286761 |          22.294145 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.255432 |           1.318179 |
| components...                  |           |                    |
| * Enabled addons:              |  0.863331 |           0.304791 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.078240 |           0.075140 |
| configured to use "minikube"   |           |                    |
|                                |  0.003375 |           0.005061 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.362641956 26.798405639 25.161442678]
Average time for minikube: 26.107496757666667

Times for Minikube (PR 8035): [25.605743837999995 27.163882138999995 27.947702657999997]
Average time for Minikube (PR 8035): 26.905776211666662

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8035) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.070698 |           0.074736 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002321 |           0.002222 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.057364 |           0.058263 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.579790 |           7.536536 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.148553 |           0.144852 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.866361 |          18.148786 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.306418 |           0.774967 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002623 |           0.092703 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.069071 |           0.066703 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004298 |           0.006007 |
+----------------------------------------+-----------+--------------------+

pkg/minikube/node/start.go

This makes sure the kubelet picks up the correct IP

This way, we won't ever enable kubelet to start when systemd starts, preventing a race condition with `/etc/hosts`

…embed-certs

minikube-pr-bot · 2020-05-08T19:45:42Z

kvm2 Driver
Times for minikube: [68.345647116 66.638088348 64.90929271099999]
Average time for minikube: 66.63100939166667

Times for Minikube (PR 8035): [64.818884178 66.516283314 67.385410189]
Average time for Minikube (PR 8035): 66.24019256033334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8035) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.075307 |           0.060020 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.022891 |           0.021833 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.005121 |           0.003204 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.229573 |          41.253572 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 23.252926 |          22.333482 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.431577 |           1.464316 |
| components...                  |           |                    |
| * Enabled addons:              |  0.527426 |           1.005232 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080879 |           0.092579 |
| configured to use "minikube"   |           |                    |
|                                |  0.005310 |           0.005953 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.441454172 27.001996296999998 27.482620685]
Average time for minikube: 27.308690384666665

Times for Minikube (PR 8035): [27.477851559999998 26.547291469 26.737603462]
Average time for Minikube (PR 8035): 26.920915497

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8035) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.075575 |           0.074180 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002298 |           0.003289 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.060196 |           0.060804 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.004977 |           7.773821 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.126471 |           0.120547 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.734918 |          17.360340 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.167269 |           1.456828 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.065318 |           0.002449 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.067672 |           0.063480 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003997 |           0.005177 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-05-08T20:05:30Z

kvm2 Driver
Times for minikube: [64.40987051399999 65.691706339 66.87414835700001]
Average time for minikube: 65.65857507

Times for Minikube (PR 8035): [65.58202054600001 68.063104392 65.66923154100002]
Average time for Minikube (PR 8035): 66.43811882633332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8035) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.058777 |           0.059587 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.019832 |           0.019305 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.006341 |           0.003154 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.132080 |          40.579448 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.044452 |          23.239858 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.380591 |           1.483024 |
| components...                  |           |                    |
| * Enabled addons:              |  0.936663 |           0.972509 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.076117 |           0.074027 |
| configured to use "minikube"   |           |                    |
|                                |  0.003722 |           0.007206 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.993441608999998 27.152778678000004 26.433766642000002]
Average time for minikube: 27.526662309666666

Times for Minikube (PR 8035): [26.515539694 25.767209800999996 26.340992532]
Average time for Minikube (PR 8035): 26.207914008999996

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8035) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.075964 |           0.076273 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002507 |           0.002577 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.062014 |           0.059531 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.965005 |           7.643556 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.149216 |           0.120777 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.995799 |          17.144969 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.146874 |           1.092231 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.060980 |           0.002730 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062305 |           0.059726 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005999 |           0.005545 |
+----------------------------------------+-----------+--------------------+

pkg/minikube/bootstrapper/kubeadm/kubeadm.go

test/integration/start_stop_delete_test.go

minikube-pr-bot · 2020-05-08T21:15:12Z

kvm2 Driver
Times for minikube: [67.472900613 64.24835347199999 63.18940491200001]
Average time for minikube: 64.97021966566666

Times for Minikube (PR 8035): [64.358291771 65.372599793 63.296837099]
Average time for Minikube (PR 8035): 64.342576221

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8035) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.067451 |           0.058107 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.021337 |           0.020132 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.010402 |           0.009718 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.285513 |          40.761059 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.476447 |          21.708966 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.649482 |           1.441301 |
| components...                  |           |                    |
| * Enabled addons:              |  0.374977 |           0.260671 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080998 |           0.077072 |
| configured to use "minikube"   |           |                    |
|                                |  0.003612 |           0.005551 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.589424716000003 26.978412671 25.333303412999996]
Average time for minikube: 26.633713599999997

Times for Minikube (PR 8035): [26.806351751 25.927312156000003 28.001350385000002]
Average time for Minikube (PR 8035): 26.91167143066667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8035) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.075991 |           0.074658 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002516 |           0.003228 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.058227 |           0.058741 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.809652 |           7.864944 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.118981 |           0.124563 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.645788 |          17.685756 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.834935 |           0.943444 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.019855 |           0.083101 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.063461 |           0.069453 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004308 |           0.003783 |
+----------------------------------------+-----------+--------------------+

medyagh

Thank you for fixing this mysterious bug. great work.

Priya Wadhwa added 2 commits May 7, 2020 12:59

Restart kubeadm on soft minikube start

c037a97

This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different. This should fix the embed-certs integration test which has been flaky for a while.

Add comments

a353d56

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2020

k8s-ci-robot requested review from blueelvis and medyagh May 7, 2020 20:04

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020

medyagh reviewed May 7, 2020

View reviewed changes

pkg/drivers/kic/kic.go Outdated Show resolved Hide resolved

medyagh requested changes May 7, 2020

View reviewed changes

pkg/drivers/kic/kic.go Outdated Show resolved Hide resolved

priyawadhwa changed the title ~~Restart kubeadm on soft minikube start~~ Restart kubelet on soft minikube start May 7, 2020

Restart kubelet in a function that is called on soft start

163ab88

Priya Wadhwa added 2 commits May 7, 2020 13:40

Restart kubelet if soft start

8ac4281

Add kic

69a39c1

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2020

Priya Wadhwa added 2 commits May 7, 2020 13:43

remove unnecessary code

ced1914

move into separate function

8096094

priyawadhwa force-pushed the embed-certs branch from 57b254a to 59446d2 Compare May 7, 2020 21:19

Add start/stop test for plain old docker

fce7562

priyawadhwa force-pushed the embed-certs branch from 59446d2 to fce7562 Compare May 7, 2020 21:19

medyagh reviewed May 7, 2020

View reviewed changes

pkg/minikube/node/start.go Outdated Show resolved Hide resolved

Add host alias back after restarting kubelet

9348667

Priya Wadhwa added 3 commits May 8, 2020 12:32

Restart kubelet after updating config files

826fb2b

This makes sure the kubelet picks up the correct IP

Remove Enable(kubelet) from unpause

0fa2499

This way, we won't ever enable kubelet to start when systemd starts, preventing a race condition with `/etc/hosts`

make it impossible to enable the kubelet service

f574852

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2020

Merge branch 'master' of https://github.com/kubernetes/minikube into …

ba26770

…embed-certs

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2020

priyawadhwa changed the title ~~Restart kubelet on soft minikube start~~ Restart kubelet on restart May 8, 2020

priyawadhwa changed the title ~~Restart kubelet on restart~~ Wait to add aliases to /etc/hosts before starting kubelet May 8, 2020

Add unit test

cb4dc30

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2020

tstromberg reviewed May 8, 2020

View reviewed changes

pkg/minikube/bootstrapper/kubeadm/kubeadm.go Outdated Show resolved Hide resolved

tstromberg reviewed May 8, 2020

View reviewed changes

pkg/minikube/bootstrapper/kubeadm/kubeadm.go Outdated Show resolved Hide resolved

Priya Wadhwa added 2 commits May 8, 2020 13:55

Remove unnecessary restart

6d1d07c

Remove unnecessary function

753dc44

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2020

medyagh requested changes May 8, 2020

View reviewed changes

test/integration/start_stop_delete_test.go Outdated Show resolved Hide resolved

Priya Wadhwa added 2 commits May 8, 2020 14:12

Copy files directly now that we control kubeadm

bfef99b

Remove test

2915aaf

medyagh approved these changes May 8, 2020

View reviewed changes

priyawadhwa requested a review from tstromberg May 8, 2020 22:19

tstromberg approved these changes May 8, 2020

View reviewed changes

medyagh merged commit 271ca3a into kubernetes:master May 8, 2020

fmotrifork mentioned this pull request May 12, 2020

minikube 1.10.0 fishworks/fish-food#725

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wait to add aliases to /etc/hosts before starting kubelet #8035

Wait to add aliases to /etc/hosts before starting kubelet #8035

priyawadhwa commented May 7, 2020 •

edited

Loading

priyawadhwa commented May 7, 2020

k8s-ci-robot commented May 7, 2020

minikube-pr-bot commented May 7, 2020

minikube-pr-bot commented May 7, 2020

minikube-pr-bot commented May 7, 2020

codecov-io commented May 7, 2020 •

edited

Loading

minikube-pr-bot commented May 7, 2020

minikube-pr-bot commented May 8, 2020

minikube-pr-bot commented May 8, 2020

minikube-pr-bot commented May 8, 2020

medyagh left a comment

Wait to add aliases to /etc/hosts before starting kubelet #8035

Wait to add aliases to /etc/hosts before starting kubelet #8035

Conversation

priyawadhwa commented May 7, 2020 • edited Loading

priyawadhwa commented May 7, 2020

k8s-ci-robot commented May 7, 2020

minikube-pr-bot commented May 7, 2020

minikube-pr-bot commented May 7, 2020

minikube-pr-bot commented May 7, 2020

codecov-io commented May 7, 2020 • edited Loading

Codecov Report

minikube-pr-bot commented May 7, 2020

minikube-pr-bot commented May 8, 2020

minikube-pr-bot commented May 8, 2020

minikube-pr-bot commented May 8, 2020

medyagh left a comment

Choose a reason for hiding this comment

priyawadhwa commented May 7, 2020 •

edited

Loading

codecov-io commented May 7, 2020 •

edited

Loading