-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option --all to stop all clusters #8285
Conversation
Hi @kadern0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kadern0 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #8285 +/- ##
==========================================
- Coverage 34.35% 34.11% -0.25%
==========================================
Files 147 153 +6
Lines 9456 9823 +367
==========================================
+ Hits 3249 3351 +102
- Misses 5808 6069 +261
- Partials 399 403 +4
|
@kadern0 - you will need to amend the commit msg to not include βfixes ...β and then force push it to get rid of the invalid commit message label. |
@prasadkatti I've updated the commit message although I thought it is a common practice to reference the issue within the commit. |
@kadern0 - yeah, I thought so too. I am not sure why it is setup that way. I had this same issue on one of my PRs a while back. So I thought I would help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for doing this PR. looks good, just a minior nit
Related to kubernetes#8237 Signed-off-by: kadern0 <kaderno@gmail.com>
Resolves #8237
Signed-off-by: kadern0 kaderno@gmail.com
Example of the PR working: