-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for offline kic #8417
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver |
Codecov Report
@@ Coverage Diff @@
## master #8417 +/- ##
==========================================
- Coverage 34.13% 34.07% -0.06%
==========================================
Files 153 153
Lines 9808 9825 +17
==========================================
Hits 3348 3348
- Misses 6058 6075 +17
Partials 402 402
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR, this PR is doing the right thing and improves kic experience.
do you mind manually making sure, the chosen Fallback image, survives Stopping cluster and starting it again. just to verify the chosen fallback will be presistiantly used across stop/start
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit
confirmed that this works locally |
kvm2 Driver Times for Minikube (PR 8417): [63.926408698 64.834971762 62.21764555799999] Averages Time Per Log
docker Driver Times for Minikube (PR 8417): [25.420945449999994 26.133872598 26.057333433] Averages Time Per Log
|
Docker Driver : TestFunctional/parallel/DockerEnv is related to this flake: |
This PR does a couple things:
--download-only=true
, if the docker daemon isn't running, store the kic base image as a tarball on the host machineThis way, we can download all required artifacts to the host machine, and later run the docker driver offline (I tested this locally and it works).
This should fix one of the bugs around running minikube in Cloud Shell.
Fixes #8366