-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker/podman: add solution message when container exits after start/create #8501
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d4d0166
to
736f521
Compare
Travis tests have failedHey @medyagh, 1st Buildmake test
TravisBuddy Request Identifier: 5f96d120-b0da-11ea-b9a3-b9754cbad7e4 |
Travis tests have failedHey @medyagh, 1st Buildmake test
TravisBuddy Request Identifier: 0a8a6180-b0e2-11ea-b9a3-b9754cbad7e4 |
Codecov Report
@@ Coverage Diff @@
## master #8501 +/- ##
==========================================
- Coverage 33.97% 33.87% -0.10%
==========================================
Files 153 154 +1
Lines 9869 9897 +28
==========================================
Hits 3353 3353
- Misses 6112 6140 +28
Partials 404 404
|
pkg/drivers/kic/oci/oci.go
Outdated
return runCmd(exec.Command(ociBin, "logs", "--timestamps", name)) | ||
} | ||
|
||
//PrintPostPortem will print relevant docker/podman infos after a container fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to log instead of print (normally associated to stdout). Perhaps LogContainerStatus
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about LogContainerDebug? since we are doing three things there
/ok-to-test |
kvm2 Driver Times for Minikube (PR 8501): [63.271461281 65.25239230300001 64.041630812] Averages Time Per Log
docker Driver Times for Minikube (PR 8501): [27.803309603000002 26.478580284999996 27.285987896] Averages Time Per Log
|
Helps with debugging issues like this: #8163
by adding a solution message and also adding postmortem
docker logs
anddocker info
logs to the verbose logafter this PR normal logs:
logs with --alsologtostderr include dokcer info and docke logs