Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make docker driver highly preferred #8623

Merged
merged 1 commit into from
Jul 1, 2020
Merged

make docker driver highly preferred #8623

merged 1 commit into from
Jul 1, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jul 1, 2020 •
edited
Loading

after this PR

on mac

medya@~/workspace/minikube (docker_prefered) $ make && ./out/minikube start
make: `out/minikube' is up to date.
😄  minikube v1.12.0-beta.0 on Darwin 10.15.5
✨  Automatically selected the docker driver
👍  Starting control plane node minikube in cluster minikube
💾  Downloading Kubernetes v1.18.3 preload ...
    > preloaded-images-k8s-v4-v1.18.3-docker-overlay2-amd64.tar.lz4: 526.27 MiB
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.3 on Docker 19.03.2 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisi

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@afbjorklund
Copy link
Collaborator

Related to #8353, but complicated by #8151

@medyagh medyagh merged commit 6a21774 into kubernetes:master Jul 1, 2020
@medyagh medyagh deleted the docker_prefered branch March 2, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medyagh @k8s-ci-robot @afbjorklund @sharifelgamal