set proxy-refresh-interval=70000 for etcd to improve CPU overhead

[priyawadhwa]

closes #5682

can be reversed back to the default via command line:

minikube start --extra-config etcd.proxy-refresh-interval=30000

[priyawadhwa]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

kvm2 Driver
docker Driver

[medyagh]

/ok-to-test

[medyagh]

@priyawadhwa the VerifyKubernetesImages test seem to be failing multiple places

[medyagh]

@priyawadhwa the VerifyKubernetesImages test seem to be failing multiple places

never mind that was related to this #8859

[medyagh]

please checkout the TestRunningBinaryUpgrade failure to see if it is related:
https://storage.googleapis.com/minikube-builds/logs/8850/1c1ac42/Docker_Linux.html#fail_TestRunningBinaryUpgrade

[priyawadhwa]

Hey @medyagh , the test passes locally so I don't think it's related to this PR:

$ make integration -e TEST_ARGS="-test.run TestRunningBinaryUpgrade  --cleanup=false --minikube-start-args="--driver=docker""
go test -v -test.timeout=60m ./test/integration --tags="integration container_image_ostree_stub containers_image_openpgp go_getter_nos3 go_getter_nogcs" -test.run TestRunningBinaryUpgrade  --cleanup=false --minikube-start-args=--driver=docker
Found 16 cores, limiting parallelism with --test.parallel=9
=== RUN   TestRunningBinaryUpgrade
=== PAUSE TestRunningBinaryUpgrade
=== CONT  TestRunningBinaryUpgrade
--- PASS: TestRunningBinaryUpgrade (394.90s)
    version_upgrade_test.go:90: (dbg) Run:  /var/folders/hh/dw0n4wk51cv_w3yl9h5p155h00fzsz/T/minikube-v1.9.0.345181553.exe start -p running-upgrade-20200728132338-22666 --memory=2200 --vm-driver=docker
    version_upgrade_test.go:90: (dbg) Done: /var/folders/hh/dw0n4wk51cv_w3yl9h5p155h00fzsz/T/minikube-v1.9.0.345181553.exe start -p running-upgrade-20200728132338-22666 --memory=2200 --vm-driver=docker: (2m54.138411203s)
    version_upgrade_test.go:100: (dbg) Run:  out/minikube start -p running-upgrade-20200728132338-22666 --memory=2200 --alsologtostderr -v=1 --driver=docker
    version_upgrade_test.go:100: (dbg) Done: out/minikube start -p running-upgrade-20200728132338-22666 --memory=2200 --alsologtostderr -v=1 --driver=docker: (3m15.541506118s)
    helpers_test.go:176: skipping cleanup of running-upgrade-20200728132338-22666 (--cleanup=false)
PASS
Tests completed in 6m34.903494774s (result code 0)
ok  	k8s.io/minikube/test/integration	395.397s

[minikube-pr-bot]

kvm2 Driver
Times for minikube: [65.321191009 63.680953118000005 61.725288301]
Average time for minikube: 63.575810809333326

Times for Minikube (PR 8850): [62.545989840000004 63.066401432999996 62.69396773]
Average time for Minikube (PR 8850): 62.768786334333335

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8850) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.059548 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020095 |           0.019274 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003585 |           0.002957 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.873980 |          40.291072 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.364525 |          20.871438 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.629065 |           1.386174 |
| components...                  |           |                    |
| * Enabled addons:              |  0.525330 |           0.063812 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.094433 |           0.073786 |
| configured to use "minikube"   |           |                    |
|                                |  0.005250 |           0.004349 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [30.469669009 29.279268442999996 28.247890380999998]
Average time for minikube: 29.332275944333333

Times for Minikube (PR 8850): [37.189274244 26.920317042 26.857239251000003]
Average time for Minikube (PR 8850): 30.322276845666664

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8850) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.067784 |                    |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.105206 |           0.101645 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.058463 |           0.056272 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  9.267444 |          11.830144 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 18.902210 |                    |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.864959 |           0.764697 |
| components...                  |           |                    |
| * Enabled addons:              |  0.002709 |           0.109059 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.060804 |           0.062560 |
| configured to use "minikube"   |           |                    |
|                                |  0.002697 |           0.067236 |
+--------------------------------+-----------+--------------------+

[medyagh]

/retest-this-please

[minikube-pr-bot]

kvm2 Driver
Times for minikube: [64.408826832 62.355156648 58.452464114]
Average time for minikube: 61.73881586466667

Times for Minikube (PR 8850): [64.327140218 61.56647187899999 63.76251608100001]
Average time for Minikube (PR 8850): 63.21870939266666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8850) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.061248 |           0.054074 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018181 |           0.017802 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.010264 |           0.003030 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 38.809939 |          40.724036 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.277872 |          20.792425 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.404581 |           1.416892 |
| components...                  |           |                    |
| * Enabled addons:              |  0.076550 |           0.139613 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.071628 |           0.066360 |
| configured to use "minikube"   |           |                    |
|                                |  0.008554 |           0.004478 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.275890397 27.761076872999997 26.579712312]
Average time for minikube: 27.538893193999996

Times for Minikube (PR 8850): [26.583717976 28.115030091 24.583832676]
Average time for Minikube (PR 8850): 26.42752691433333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8850) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.2 on Debian   |  0.065246 |           0.065726 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.106029 |           0.098190 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.058050 |           0.055065 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  8.533821 |           8.451395 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.827365 |          16.816732 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.839009 |           0.826601 |
| components...                  |           |                    |
| * Enabled addons:              |  0.036788 |           0.042838 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.063933 |           0.063855 |
| configured to use "minikube"   |           |                    |
|                                |  0.008652 |           0.007124 |
+--------------------------------+-----------+--------------------+