Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Desktop instructions if memory is >minimum but <recommended #9181

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

tstromberg
Copy link
Contributor

This updates the warning when the user has more than minimum amount of memory, but less than the warning amount, so that Docker Desktop users get exact instructions for how to repair it.

Old UX

✨  Automatically selected the docker driver. Other choices: hyperkit, parallels, vmware, virtualbox, vmwarefusion

⛔  Requested memory allocation (1235MB) is less than the recommended minimum 2000MB. Deployments may fail.

👍  Starting control plane node minikube in cluster minikube

New UX

✨  Using the docker driver based on existing profile

⛔  Docker Desktop only has 984MiB available, you may encounter application deployment failures
💡  Suggestion: 

    1. Click on "Docker for Desktop" menu icon
    2. Click "Preferences"
    3. Click "Resources"
    4. Increase "Memory" slider bar to 2.25 GB or higher
    5. Click "Apply & Restart"
📘  Documentation: https://docs.docker.com/docker-for-mac/#resources

👍  Starting control plane node minikube in cluster minikube

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@tstromberg tstromberg merged commit c4663b8 into kubernetes:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants