Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildroot 2020.02.6 #9329

Merged
merged 4 commits into from
Oct 12, 2020
Merged

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Sep 27, 2020

Closes #7904

Still has the old LTS kernel, which should hopefully avoid the regressions from last time (PR #8187)

Do the kernel upgrade separately, for easier ISO testing

Use the same kernel version as was in "2019.02.x" branch
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2020
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Sep 27, 2020

It seems like the iso.log wasn't uploaded anywhere ?

     - name: Build ISO
        run: |
          whoami
          make minikube_iso &> ./out/iso.log
          make checksum

No artifacts

No artifacts were generated.

      - uses: actions/upload-artifact@v1
        with:
          name: iso_functional_test_kvm2_ubuntu
          path: out/report
      - uses: actions/upload-artifact@v1
        with:
          name: iso log
          path: out/iso.log

As if it skipped the upload steps, when the make failed ?

EDIT: Apparently it needs a line added:

if: always()

@medyagh
Copy link
Member

medyagh commented Sep 30, 2020

if: always()

Yes feel free to add that in this PR please

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2020
@afbjorklund
Copy link
Collaborator Author

We got the log now, at least. Some packages are building with the wrong go compiler (host instead of target)

compile: version "go1.14.6" does not match go tool version "go1.13.14"

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2020
@dalehamel
Copy link
Contributor

Ah, just saw this, we should not merge #9394 until after this lands, as this would conflict. Being on the newer image would clean up a bunch of the erroneously generated configs.

@dalehamel
Copy link
Contributor

It seems like the iso.log wasn't uploaded anywhere ?

and

Yes feel free to add that in this PR please

I ran into this while trying to figure out why the current branch is breaking in the ISO build, and started #9395 wip to try and debug github actions.

I know this isn't the right place to discuss it, but I'm curious why doesn't this just print to stdout? If we want to keep the logfile and upload it separately, we can pipe to tee. The PR i'm actually trying to land (to fix #8637 ) is failing after 50 minutes and I have no way to access the build log.

@dalehamel
Copy link
Contributor

We got the log now, at least. Some packages are building with the wrong go compiler (host instead of target)
compile: version "go1.14.6" does not match go tool version "go1.13.14"

I got this exact failure in my branch also, based off of master. I believe this issue is not isolated to this branch, and it looks like all of the CI "ISO" builds are failing because of it. I'll cut a separate issue for this and try to address this in another PR to fix CI.

@afbjorklund
Copy link
Collaborator Author

We got the log now, at least. Some packages are building with the wrong go compiler (host instead of target)
compile: version "go1.14.6" does not match go tool version "go1.13.14"

I got this exact failure in my branch also, based off of master. I believe this issue is not isolated to this branch, and it looks like all of the CI "ISO" builds are failing because of it. I'll cut a separate issue for this and try to address this in another PR to fix CI.

Just want to mention (as was done elsewhere), that it is fixed by d8e39a2

@afbjorklund
Copy link
Collaborator Author

@medyagh:
What was remaining before merging this and fixing #7904 ? I don't think we can do a more minimal OS upgrade.

@medyagh medyagh merged commit 0c7284a into kubernetes:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Buildroot to 2020.02 LTS
4 participants