-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildroot 2020.02.6 #9329
Buildroot 2020.02.6 #9329
Conversation
This was missed in 8f9c572
Do the kernel upgrade separately, for easier ISO testing Use the same kernel version as was in "2019.02.x" branch
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems like the iso.log wasn't uploaded anywhere ? - name: Build ISO
run: |
whoami
make minikube_iso &> ./out/iso.log
make checksum
- uses: actions/upload-artifact@v1
with:
name: iso_functional_test_kvm2_ubuntu
path: out/report
- uses: actions/upload-artifact@v1
with:
name: iso log
path: out/iso.log
As if it skipped the upload steps, when the make failed ? EDIT: Apparently it needs a line added:
|
Yes feel free to add that in this PR please |
We got the log now, at least. Some packages are building with the wrong go compiler (host instead of target)
|
3a2ffd8
to
d8e39a2
Compare
Ah, just saw this, we should not merge #9394 until after this lands, as this would conflict. Being on the newer image would clean up a bunch of the erroneously generated configs. |
and
I ran into this while trying to figure out why the current branch is breaking in the ISO build, and started #9395 wip to try and debug github actions. I know this isn't the right place to discuss it, but I'm curious why doesn't this just print to stdout? If we want to keep the logfile and upload it separately, we can pipe to |
I got this exact failure in my branch also, based off of master. I believe this issue is not isolated to this branch, and it looks like all of the CI "ISO" builds are failing because of it. I'll cut a separate issue for this and try to address this in another PR to fix CI. |
Just want to mention (as was done elsewhere), that it is fixed by d8e39a2 |
Closes #7904
Still has the old LTS kernel, which should hopefully avoid the regressions from last time (PR #8187)