Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default linux config to support ftrace, for bpf tracing, fixes #8637 #9393

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

dalehamel
Copy link
Contributor

@dalehamel dalehamel commented Oct 5, 2020

This should fix #8637

My goal here is to be able to use minikube with bpftrace / bcc.

In order to do this, they need to be able to list the available filter functions.

Prior to this change, /sys/kernel/debug/tracing/available_filter_functions does not exist. After this change, the file exists. I have not been able to verify end-to-end that everything works yet, but this is a good start.

These changes should be safe to merge, as all of the Linux kernel tracing features must be explicitly be enabled by a user. Almost all production systems should have these flags enabled anyways, so it's quite clear that they do not harm performance on their own.

As a side note, while preparing this PR, i believe I've found evidence that the linux config has been edited directly by users, or is otherwise somehow out of sync with the machine-generated config. I created #9394 to remedy this.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @dalehamel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dalehamel
To complete the pull request process, please assign priyawadhwa after the PR has been reviewed.
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dalehamel
Copy link
Contributor Author

Looks like bpftrace is happy after this change:

$ curl https://raw.githubusercontent.com/iovisor/bpftrace/master/scripts/check_kernel_features.sh | bash -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   859  100   859    0     0   7953      0 --:--:-- --:--:-- --:--:--  7953
All required features present!

@dalehamel
Copy link
Contributor Author

ISO build on CI seems broken?

@dalehamel
Copy link
Contributor Author

Started a draft PR #9395 to see why the ISO build is failing

@tstromberg
Copy link
Contributor

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel with CONFIG_FTRACE_SYSCALLS kubectl-trace
4 participants