-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default linux config to support ftrace, for bpf tracing, fixes #8637 #9393
Update default linux config to support ftrace, for bpf tracing, fixes #8637 #9393
Conversation
Hi @dalehamel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dalehamel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Looks like bpftrace is happy after this change:
|
ISO build on CI seems broken? |
Started a draft PR #9395 to see why the ISO build is failing |
LGTM. |
This should fix #8637
My goal here is to be able to use minikube with bpftrace / bcc.
In order to do this, they need to be able to list the available filter functions.
Prior to this change,
/sys/kernel/debug/tracing/available_filter_functions
does not exist. After this change, the file exists. I have not been able to verify end-to-end that everything works yet, but this is a good start.These changes should be safe to merge, as all of the Linux kernel tracing features must be explicitly be enabled by a user. Almost all production systems should have these flags enabled anyways, so it's quite clear that they do not harm performance on their own.
As a side note, while preparing this PR, i believe I've found evidence that the linux config has been edited directly by users, or is otherwise somehow out of sync with the machine-generated config. I created #9394 to remedy this.