-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --node option for command ip
and ssh-key
#9873
Add --node option for command ip
and ssh-key
#9873
Conversation
Hi @lingsamuel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
bd922be
to
1a1afa9
Compare
1a1afa9
to
b9eedce
Compare
/retest |
@lingsamuel: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
Edit: ssh and ssh-host already had --node parameter /ok-to-test |
kvm2 Driver |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lingsamuel, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Provides options
-n, --node
for commandip
andssh-key
while minikube now support multi-node.Example: