-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete 'vmwarefusion' driver, add friendly message #9958
Conversation
/ok-to-test |
kvm2 Driver |
@tstromberg :
The are issues opened against both Workstation 15 and against Fusion 11.
See https://www.vmware.com/products/desktop-hypervisor.html Interestingly, they recommend minikube for kubernetes even despite that:
https://www.vmware.com/topics/glossary/content/kubernetes-cluster |
We should still obsolete the "vmwarefusion" driver, just that "vmware" needs fixing too... |
@@ -47,7 +47,7 @@ const ( | |||
HyperKit = "hyperkit" | |||
// VMware driver | |||
VMware = "vmware" | |||
// VMwareFusion driver | |||
// VMwareFusion driver (obsolete) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also just delete it ? That is what we did with kvm and xhyve, for instance (0332f73)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The vmwarefusion driver has been broken for 6+ months. Fixes #8374
With this PR, this is the behavior when
--driver=vmwarefusion
is provided: