-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule for docker image pull error #117
Conversation
/assign @Random-Liu |
config/docker-monitor-filelog.json
Outdated
"rules": [] | ||
"rules": [ | ||
{ | ||
"type": "permanent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this problem is permanent, you may want to add a condition for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to temporary.
config/docker-monitor-filelog.json
Outdated
{ | ||
"type": "permanent", | ||
"reason": "CorruptDockerImage", | ||
"pattern": "container start failed: ErrImagePull: (.+): directory not empty" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a kubelet log. Are your should this is docker log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I had published outdated changes. Fixed it.
ping ... Thanks! |
@dchen1107: waiting for @Random-Liu to review. |
@ajitak Have you tried the rule for journald? Does it work?\ I guess it will not. |
I have not been able inject messages in journald. I tested regex with docker log string to test the pattern. |
@Random-Liu @ajitak: What's required to move this forward, or can it be moved out of 1.7? |
@Random-Liu Updated the regex and tested it. When I run kubectl describe node node-name command, I see following under events: |
Add a new rule which catches docker image corruption (cherrypick #117 to v0.4)
Add a new rule which catches docker image corruption. It will address kubernetes/kubernetes#47219
This change is