Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onboarding the rest of 1.25 release team #3500

Merged
merged 1 commit into from
Jun 14, 2022
Merged

onboarding the rest of 1.25 release team #3500

merged 1 commit into from
Jun 14, 2022

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Jun 13, 2022

onboarding the rest of 1.25 release team

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 13, 2022
@cici37
Copy link
Contributor Author

cici37 commented Jun 13, 2022

/cc @reylejano @salaxander @gracenng @jlbutler @leonardpahlke
/assign @jeremyrickard

@leonardpahlke
Copy link
Member

The following members of team release-team are not Kubernetes org members: krol3

ref: #3478

Oh, I see there seems to be a typo and @krol was invited, not @krol3

cc @mrbobbytables

reylejano
reylejano reviewed Jun 13, 2022
View reviewed changes
config/kubernetes/sig-release/teams.yaml
- jyotimahapatra # 1.25 CI Signal Shadow
- katcosgrove # 1.25 Comms Lead
- kcmartin # 1.25 Docs Lead
# - krol3 # 1.25 Docs Shadow
- krol3 # 1.25 Docs Shadow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- krol3 # 1.25 Docs Shadow
- krol # 1.25 Docs Shadow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

krol3 should be correct but the org membership got send to krol :D. I can open a PR to fix it

Copy link
Contributor Author

@cici37 cici37 Jun 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this!

@leonardpahlke leonardpahlke mentioned this pull request Jun 13, 2022
Merged
@leonardpahlke
Copy link
Member

/retest

@leonardpahlke
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@leonardpahlke
Copy link
Member

/approve

@reylejano
Copy link
Member

/lgtm
/approve

@reylejano
Copy link
Member

/assign @jeremyrickard

@jeremyrickard
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, jeremyrickard, leonardpahlke, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5c417ba into kubernetes:main Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 14, 2022
@cici37 cici37 deleted the 1.25-onboarding branch June 14, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano reylejano left review comments

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@gracenng gracenng Awaiting requested review from gracenng

@jlbutler jlbutler Awaiting requested review from jlbutler

@leonardpahlke leonardpahlke Awaiting requested review from leonardpahlke

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@jeremyrickard jeremyrickard

@reylejano reylejano

@leonardpahlke leonardpahlke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@cici37 @leonardpahlke @reylejano @jeremyrickard @k8s-ci-robot