Add csi-misc team to tag all developers #390
Conversation
k8s-ci-robot
added
do-not-merge/hold
config/kubernetes-csi/org.yaml
Outdated
| @@ -327,3 +327,20 @@ teams: | |||
| - lpabon | |||
| - saad-ali | |||
| privacy: closed | |||
| csi-misc: | |||
| description: Miscellaneous Discussions for Kubernetes CSI Work Group | |||
config/kubernetes-csi/org.yaml
Outdated
| - pohly | ||
| - rootfs | ||
| - sbezverk | ||
| - vladimirvivien |
There was a problem hiding this comment.
Can you add me? xing-yang
There was a problem hiding this comment.
I tried:
config_test.go:248: The following members of team csi-misc are not Kubernetes CSI org members: xing-yang
There was a problem hiding this comment.
Oh, csi-org, I can fix that easily here.
There was a problem hiding this comment.
Maybe I need to apply for kubernetes-csi org membership first? I should do that anyway.
There was a problem hiding this comment.
@xing-yang -- You'll need to apply for membership for the kubernetes-csi org before @jsafrane can add you to this GitHub team.
There was a problem hiding this comment.
My membership application is approved and I'm added to kubernetes-csi org now.
There was a problem hiding this comment.
Thanks for sorting that! :)
jsafrane
force-pushed
the
csi-wg
branch
2 times, most recently
from
326b546
to
1d88e26
Compare
There was a problem hiding this comment.
@xing-yang needs to file for membership in a separate issue. Please remove her from the PR in the meantime.
/hold
|
@justaugustus Will do. Thanks. |
|
@justaugustus I submitted an issue to apply for membership: #392 |
|
#392 was closed yesterday. I think the only follow-up question from @justaugustus regarding possibly just changing the name to |
|
On yesterday's CSI WG meeting we found @kubernetes-csi/csi-misc good enough. IMO, it gives us possibility to add /csi-pr-reviews and /csi-bugs later. @kubernetes-csi/csi looks odd. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
SGTM |
k8s-ci-robot
added
the
lgtm
config/kubernetes-csi/org.yaml
Outdated
| @@ -28,6 +28,7 @@ members: | |||
| - saad-ali | |||
| - sbezverk | |||
| - vladimirvivien | |||
| - xing-yang | |||
There was a problem hiding this comment.
Can you rebase away this line please?
|
/lgtm cancel Rebase requested. |
k8s-ci-robot
removed
the
lgtm
For CSI development we need to tag all developers in PRs and issues. IMO, we don't need separate csi-pr-reviews and csi-bugs teams, everybody does everything.
|
rebased |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
config/kubernetes-csi/org.yaml
Outdated
| @@ -330,3 +330,21 @@ teams: | |||
| - lpabon | |||
| - saad-ali | |||
| privacy: closed | |||
| csi-misc: | |||
There was a problem hiding this comment.
nit: can we have this in the alphabetical order? all team names are currently listed alphabetically
(i'll add a test for this later)
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, justaugustus, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
For CSI development we need to tag all developers in PRs and issues. IMO, we don't need separate csi-pr-reviews and csi-bugs teams, everybody does everything,
@csi-miscin anykubernetes-csirepo should be enough.Do we need the same team in
kubernetes/repos?/hold
for discussion in sig-storage first.
@chakri-nelluri @davidz627 @gnufied @lpabon @pohly @rootfs @sbezverk @vladimirvivien @xing-yang @saad-ali @childsb , PTAL. Feel free to suggest other members or remove yourself.