Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: Update list with v1.6 CAPI Release Team Members GitHub handles #4353

Merged
merged 1 commit into from
Aug 1, 2023
Merged

CAPI: Update list with v1.6 CAPI Release Team Members GitHub handles #4353

merged 1 commit into from
Aug 1, 2023

Conversation

furkatgofurov7
Copy link
Member

New CAPI v1.6 RT members announced here: https://kubernetes.slack.com/archives/C8TSNPY4T/p1690324526230509

This PR:

  • removes old and adds new v1.6 RT members from/to the list in alphabetical order

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Jul 28, 2023
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2023
@furkatgofurov7
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@sbueringer
Copy link
Member

In general lgtm +/- figuring out the org membership situation

@furkatgofurov7
Copy link
Member Author

Added the members who have a pending membership in the commented lines as suggested by @fabriziopandini for now and we can update the list later once they acquire it.

@furkatgofurov7
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2023
@sbueringer
Copy link
Member

/lgtm
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2023
@furkatgofurov7
Update list with v1.6 CAPI Release Team Members GitHub handles.
6164692 
For the time being, GH handles who do not have org membership are added in a
commented line.

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2023
@furkatgofurov7
Copy link
Member Author

@vincepri @sbueringer @CecileRobertMichon can you please help merging this if there are no more comments?

@furkatgofurov7 furkatgofurov7 mentioned this pull request Aug 1, 2023
Closed
29 tasks
@mjlshen mjlshen mentioned this pull request Aug 1, 2023
Closed
9 tasks
vincepri
vincepri approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
CecileRobertMichon
CecileRobertMichon reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5cec49f into kubernetes:main Aug 1, 2023
@furkatgofurov7 furkatgofurov7 deleted the add-capiv1-6-members branch August 1, 2023 17:09
@palnabarun palnabarun mentioned this pull request Aug 1, 2023
Merged
@mjlshen mjlshen mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@vincepri vincepri vincepri approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@vincepri vincepri

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@furkatgofurov7 @sbueringer @k8s-ci-robot @vincepri @CecileRobertMichon