-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Run 'dep init' to create Gopkg.{toml,lock} #6
Conversation
/cc @carolynvs @munnerz |
@sttts: GitHub didn't allow me to request PR reviews from the following users: carolynvs. Note that only kubernetes members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @sdboyer |
@sttts: GitHub didn't allow me to request PR reviews from the following users: sdboyer. Note that only kubernetes members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wait, this sounds like a dep bug? is the "report" you're referring to an issue that was filed? i don't recall seeing one, though i haven't been as diligent as usual this week. |
I believe that was only a quick test with https://github.com/kubernetes-dep-experiment/client-go. Don't know that we have an issue for that, probably not. @munnerz can you comment? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Possibly a simple route: #55 |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Golang/dep does not support picking up these dependencies yet properly. But at least
dep will warn the user when he chooses incompatible dependencies (so did @munnerz report, but with
dep init --gopath
I did not even get warnings, but it picked up master which it shouldn't).A test run was published to https://github.com/kubernetes-dep-experiment/client-go
The goal is to vendor k8s.io/client-go, api, apimachinery and all other direct and transistive dependencies of client-go in the versions that are specified in https://github.com/kubernetes-dep-experiment/client-go's Gopkg.{toml,lock} with only specifying the right branch or tag of client-go, i.e.
For testing purposes one has to define the source for client-go, api and apimachinery to be in the kubernetes-dep-experiment org:
Compare https://github.com/sttts/kube-dep-test/blob/master/Gopkg.toml for a test project.