Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated k8s.gcr.io container image registry still in use #2904

Closed
rjsadow opened this issue Feb 9, 2023 · 4 comments
Closed

Deprecated k8s.gcr.io container image registry still in use #2904

rjsadow opened this issue Feb 9, 2023 · 4 comments
Assignees
@rjsadow
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@rjsadow
Copy link
Contributor

rjsadow commented Feb 9, 2023

What happened:

There are several uses of the deprecating k8s.gcr.io registry in k/release. These need to be updated and moved prior to the April 3rd freeze of the registry.

Tracking: kubernetes/k8s.io#4738
Search results: https://cs.k8s.io/?q=k8s.gcr.io&i=nope&files=&excludeFiles=vendor%2F&repos=kubernetes/release
@rjsadow rjsadow added area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 9, 2023
@rjsadow
Copy link
Contributor Author

rjsadow commented Feb 9, 2023 •
edited
Loading

Hi all,

I'd like to help update some of these references but want to double check a few things with someone more knowledgeable first.

.github/workflows/scorecards-analysis.yml - I believe this can be a straight replace.
dependencies.yaml - Is this document safe to change? My understanding is that it's to track dependencies but not necessarily used during any build/release process, is that true?
images/build/debian-iptables/Makefile - Straight replace should be fine, I've confirmed registry.k8s.io/build-image/debian-base-${ARCH} and registry.k8s.io/build-image/go-runner are present for the latest build versions.
images/build/debian-iptables/README.md - Doc updated with debian-iptables change
images/build/distroless-iptables/Makefile - Similar to debian-iptables, it uses go-runner at the same version
images/build/distroless-iptables/README.md - Doc update with distroless-iptables change
images/build/setcap/Makefile - Similar to debuan-iptalbes it uses registry.k8s.io/build-image/debian-base-${ARCH} at the same version.
images/build/setcap/README.md - Doc update with setcap
images/k8s-cloud-builder/Dockerfile - Should be a straight replace, I've verified registry.k8s.io/build-image/kube-cross exists for all currently used variants
pkg/announce/announce.go - Logging output, straight replace.
pkg/release/images_test.go - Logging output, straight replace.
push-build.sh - I don't actually see where or how the variables GCRIO_PATH_MOCK or KUBE_CROSS_CONFIG_LOCATION are being used within the script. I'm not sure the implications of changing this reference.

There are a few other references from the search results which can be kept or marked as relative (krel test data)

@rjsadow
Copy link
Contributor Author

rjsadow commented Feb 9, 2023 •
edited
Loading

/assign

@rjsadow
Copy link
Contributor Author

rjsadow commented Feb 9, 2023

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Feb 9, 2023
@rjsadow rjsadow mentioned this issue Feb 9, 2023
Merged
@mrbobbytables mrbobbytables mentioned this issue Feb 9, 2023
Closed
85 tasks
@sftim
Copy link
Contributor

sftim commented Feb 13, 2023

/retitle Deprecated k8s.gcr.io container image registry still in use

@k8s-ci-robot k8s-ci-robot changed the title Deprecating k8s.grc.io registry still in use Deprecated k8s.gcr.io container image registry still in use Feb 13, 2023
@rjsadow rjsadow mentioned this issue Feb 16, 2023
Merged
@rjsadow rjsadow closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjsadow rjsadow

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rjsadow @k8s-ci-robot @sftim