Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Umbrella Issue] Migrate K8s projects from k8s.gcr.io -> registry.k8s.io #4738

Closed
79 of 85 tasks
mrbobbytables opened this issue Feb 8, 2023 · 30 comments
Closed
79 of 85 tasks

[Umbrella Issue] Migrate K8s projects from k8s.gcr.io -> registry.k8s.io #4738

mrbobbytables opened this issue Feb 8, 2023 · 30 comments
Assignees
@riaankleinhans
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.

Comments

@mrbobbytables
Copy link
Member

mrbobbytables commented Feb 8, 2023 •
edited
Loading

With the change to defaulting to registry.k8s.io as our image registry and the planned freeze in April, projects within the Kubernetes orgs should update their image references to point to the new address.

Below is a list of repos that were surfaced in a "dumb" search for k8s.gcr.io, there may be valid references or false positives and they should be checked more closely.

NOTE: We can ignore references to staging-k8s.gcr.io, but any other references to k8s.gcr.io should be updated to registry.k8s.io

Repos with k8s.gcr.io found in search
@mrbobbytables mrbobbytables added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Feb 8, 2023
@rjsadow
Copy link

rjsadow commented Feb 8, 2023

I believe kubernetes-sigs/release-notes can be ignored/marked as complete. All references to k8s.gcr.io are from previous release notes and valid references.

@sftim
Copy link
Contributor

sftim commented Feb 8, 2023

There's also kubernetes/website#39353

hh added a commit to hh/apiserver that referenced this issue Feb 8, 2023
@hh
Migrate apiserver to registry.k8s.io
e46bac2 
Part of kubernetes/k8s.io#4738
@hh hh mentioned this issue Feb 8, 2023
Closed
@hh
Copy link
Member

hh commented Feb 8, 2023 •
edited
Loading

@Riaankl can you take a look at some of these?
/assign @Riaankl

@liggitt
Copy link
Member

liggitt commented Feb 8, 2023

there's a couple staging repos listed that should not be modified directly, but instead should be fixed within the kubernetes/kubernetes repo:

 kubernetes/apiserver
 kubernetes/pod-security-admission

@hh
Copy link
Member

hh commented Feb 8, 2023

Thanks for the clarity @liggitt !

hh added a commit to hh/kubernetes that referenced this issue Feb 8, 2023
@hh
Migrate apiserver to registry.k8s.io
75da0cc 
Part of kubernetes/k8s.io#4738
@mrbobbytables
Copy link
Member Author

I'll update the list re:staging repos
A simple find/replace works for some, but others do require more knowledge (valid references to k8s.gcr.io) or should be broken into multiple PRs (e.g. for each localization in k/website)

@hh hh mentioned this issue Feb 8, 2023
Merged
@BenTheElder
Copy link
Member

kubernetes-sigs/kind search results are false positives:

  1. containerd being configured to use registry.k8s.io as a mirror for k8s.gcr.io pulls
  2. test data for image reference parsing

There will be many similar instances.

For test data it would be OK to update to registry.k8s.io. The mirror config like this should stay, however.

@BenTheElder
Copy link
Member

BenTheElder commented Feb 8, 2023 •
edited
Loading

This should probably turn into a series of issues like kubernetes/test-infra#28665 linking back here so repo owners can handle them with local context. Some of them won't be good first issue, some will.

@mrbobbytables
Copy link
Member Author

Agreed, especially for the bigger ones like k/k.
It's on my todo to start creating follow ups, I wanted to stub this out and bring it up to the chair and tl meeting/slack after a little more work.

@ameukam
Copy link
Member

ameukam commented Feb 8, 2023 •
edited
Loading

/help wanted

@ameukam ameukam added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 8, 2023
@mrbobbytables mrbobbytables removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 8, 2023
@mrbobbytables mrbobbytables mentioned this issue Feb 8, 2023
Closed
3 tasks
@vaibhav2107 vaibhav2107 mentioned this issue Feb 9, 2023
Merged
@mengjiao-liu mengjiao-liu mentioned this issue Feb 9, 2023
Merged
@rjsadow rjsadow mentioned this issue Feb 9, 2023
Closed
@mrbobbytables mrbobbytables mentioned this issue Feb 9, 2023
Closed
@rjsadow rjsadow mentioned this issue Feb 9, 2023
Merged
This was referenced Feb 9, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 6, 2023
Merged
Merged
Merged
@xmudrii
Copy link
Member

xmudrii commented Mar 6, 2023 •
edited
Loading

@mrbobbytables Here are some additional PRs that I created and collected:

@xmudrii xmudrii mentioned this issue Mar 6, 2023
Merged
@dims dims mentioned this issue Mar 6, 2023
Closed
@dims
Copy link
Member

dims commented Mar 6, 2023

xref: #4872

@mrbobbytables
Copy link
Member Author

Thanks @xmudrii I've updated the parent issue with links to the PRs 👍

@xmudrii xmudrii mentioned this issue Mar 6, 2023
Closed
@mkumatag mkumatag mentioned this issue Mar 10, 2023
Merged
@BenTheElder
Copy link
Member

kubernetes/test-infra is done in kubernetes/test-infra#28985

The remaining references will not be removed until we flip github.com/kubernetes/k8s.io to only publish to registry.k8s.io and re-arrange the manifests etc. A full listing of remaining references and why they're there is in the PR body.

@BenTheElder BenTheElder mentioned this issue Mar 16, 2023
Closed
@pkprzekwas pkprzekwas mentioned this issue Mar 23, 2023
Closed
This was referenced Apr 10, 2023
Merged
Merged
Merged
Merged
@xmudrii
Copy link
Member

xmudrii commented Apr 10, 2023

@mrbobbytables I did another run through the checklist. kubernetes-sigs/cluster-proportional-vertical-autoscaler is done. I'm also following up on k/docs.

@mrbobbytables
Copy link
Member Author

thanks @xmudrii

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2023
@riaankleinhans
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2024
@xmudrii
Copy link
Member

xmudrii commented Jan 24, 2024

@mrbobbytables @BenTheElder @Riaankl Should we consider this as done given that almost all repos are migrated or should we do another round of checks to be sure?

@mrbobbytables
Copy link
Member Author

I think we can, any issues should have bubbled up by now 👍

thanks for checking in.

/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closing this issue.

In response to this:

I think we can, any issues should have bubbled up by now 👍

thanks for checking in.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riaankleinhans riaankleinhans

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace k8s.gcr.io references with registry.k8s.io pkprzekwas/promo-tools