Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo-infra dependencies #178

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Update repo-infra dependencies #178

merged 1 commit into from
Mar 3, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Mar 2, 2020 •
edited
Loading

  • bazel-gazelle 0.20.0
  • golangci-lint 1.23.7
  • bazel-toolchains 2.1.1 -- supports bazel 2.1.1 oob
  • protobuf 3.11.4
  • rules_go 0.22.1
  • Load rules_proto, rules_nodejs and buildtools in load.bzl

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@fejta
Copy link
Contributor Author

fejta commented Mar 2, 2020 •
edited
Loading

/retest

On my computer:

//hack:verify-golangci-lint                                              PASSED in 3.7s

Mysterious...

@fejta fejta assigned fejta and unassigned BenTheElder Mar 2, 2020
@fejta fejta assigned BenTheElder and mikedanese and unassigned fejta Mar 2, 2020
@fejta
Copy link
Contributor Author

fejta commented Mar 2, 2020

Passing tests now (needed the golangci lint needs the golang sources, which are now passed into this test target)

BenTheElder
BenTheElder reviewed Mar 3, 2020
View reviewed changes
.bazelrc
@@ -26,6 +26,9 @@ build:remote --remote_timeout=3600
# Alt: --google_credentials=some_file.json
build:remote --google_default_credentials=true

# Improve cache hit rate
build:remote --incompatible_strict_action_env=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh yep, this WAS on by default at one point bazelbuild/bazel#7026 bazelbuild/bazel#6648

@BenTheElder
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit f08c9e0 into kubernetes:master Mar 3, 2020
@fejta fejta deleted the minor branch March 3, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

Assignees

@BenTheElder BenTheElder

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fejta @k8s-ci-robot @BenTheElder @mikedanese