Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update url for kubernetes-dev mailing list to new location #1809

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

csantanapr
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Is better to have direct link to the new location of mailing list for dev@kubernetes.io

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

This was s recent change, the mailing list change location

/assign @AuraSinis

Signed-off-by: Carlos Santana <csantana23@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 10, 2022
@csantanapr
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 10, 2022
@@ -24,7 +24,7 @@ hold and only released once approved by a SIG Release (subproject) owner.**
- [ ] Has joined the following mailing lists:
- [kubernetes-sig-release](https://groups.google.com/forum/#!forum/kubernetes-sig-release)
- [kubernetes-release-team](https://groups.google.com/a/kubernetes.io/g/release-team)
- [kubernetes-dev](https://groups.google.com/forum/#!forum/kubernetes-dev)
- [kubernetes-dev](https://groups.google.com/a/kubernetes.io/group/dev)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
- [kubernetes-dev](https://groups.google.com/a/kubernetes.io/group/dev)
- [kubernetes-dev](https://groups.google.com/a/kubernetes.io/g/dev)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert I did a find and replace on the repo to replace the url.
The url (…/goup/dev) that I used is the one that is in the old mailing list telling users with a message and this url.

It looks like both are correct …/group/dev and …/g/dev the first one redirects to the second one with the g.

@saschagrunert
Copy link
Member

Thank you for the cleanup @csantanapr, I just have a nit ☝️

Signed-off-by: Carlos Santana <csantana23@gmail.com>
@csantanapr
Copy link
Member Author

Thank you @saschagrunert for the PR review 🙏 I addressed your comments. 👍

@@ -15,7 +15,7 @@ To ensure quality communication SIG Release Chairs and Technical Leads should:
- kubernetes-release-team:
https://groups.google.com/a/kubernetes.io/g/release-team
- kubernetes-dev:
https://groups.google.com/forum/#!forum/kubernetes-dev
https://groups.google.com/a/kubernetes.io/group/dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can apply the same here https://groups.google.com/a/kubernetes.io/g/dev

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check again, I swear I did a find and replace all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @cpanato those where not markdown links

@@ -185,7 +185,7 @@ krel announce send --tag vX.Y.0-{alpha,beta,rc}.Z --name "<Your Name>" --name <Y
See the [Release Commands Cheat Sheet](https://github.com/kubernetes/sig-release/blob/master/release-engineering/role-handbooks/patch-release-team.md#release-commands-cheat-sheet) for example commands.

[k-announce-list]: https://groups.google.com/forum/#!forum/kubernetes-announce
[k-dev-list]: https://groups.google.com/forum/#!forum/kubernetes-dev
[k-dev-list]: https://groups.google.com/a/kubernetes.io/group/dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here as well

@@ -155,7 +155,7 @@ Send a Slack message to those that you select, e.g:
You'll then want to join these mailing lists if you haven't already:
>- https://groups.google.com/forum/#!forum/kubernetes-sig-release
>- https://groups.google.com/forum/#!forum/kubernetes-sig-docs
>- https://groups.google.com/forum/#!forum/kubernetes-dev
>- https://groups.google.com/a/kubernetes.io/group/dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more :)

Signed-off-by: Carlos Santana <csantana23@gmail.com>
@csantanapr
Copy link
Member Author

Thanks for the review @cpanato 🙏 I addressed your comments

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, csantanapr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 31334aa into kubernetes:master Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants