-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update url for kubernetes-dev mailing list to new location #1809
update url for kubernetes-dev mailing list to new location #1809
Conversation
Signed-off-by: Carlos Santana <csantana23@gmail.com>
/kind cleanup |
.github/ISSUE_TEMPLATE/lead.md
Outdated
@@ -24,7 +24,7 @@ hold and only released once approved by a SIG Release (subproject) owner.** | |||
- [ ] Has joined the following mailing lists: | |||
- [kubernetes-sig-release](https://groups.google.com/forum/#!forum/kubernetes-sig-release) | |||
- [kubernetes-release-team](https://groups.google.com/a/kubernetes.io/g/release-team) | |||
- [kubernetes-dev](https://groups.google.com/forum/#!forum/kubernetes-dev) | |||
- [kubernetes-dev](https://groups.google.com/a/kubernetes.io/group/dev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
- [kubernetes-dev](https://groups.google.com/a/kubernetes.io/group/dev) | |
- [kubernetes-dev](https://groups.google.com/a/kubernetes.io/g/dev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saschagrunert I did a find and replace on the repo to replace the url.
The url (…/goup/dev
) that I used is the one that is in the old mailing list telling users with a message and this url.
It looks like both are correct …/group/dev
and …/g/dev
the first one redirects to the second one with the g
.
Thank you for the cleanup @csantanapr, I just have a nit ☝️ |
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Thank you @saschagrunert for the PR review 🙏 I addressed your comments. 👍 |
leads/onboarding.md
Outdated
@@ -15,7 +15,7 @@ To ensure quality communication SIG Release Chairs and Technical Leads should: | |||
- kubernetes-release-team: | |||
https://groups.google.com/a/kubernetes.io/g/release-team | |||
- kubernetes-dev: | |||
https://groups.google.com/forum/#!forum/kubernetes-dev | |||
https://groups.google.com/a/kubernetes.io/group/dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe can apply the same here https://groups.google.com/a/kubernetes.io/g/dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check again, I swear I did a find and replace all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @cpanato those where not markdown links
@@ -185,7 +185,7 @@ krel announce send --tag vX.Y.0-{alpha,beta,rc}.Z --name "<Your Name>" --name <Y | |||
See the [Release Commands Cheat Sheet](https://github.com/kubernetes/sig-release/blob/master/release-engineering/role-handbooks/patch-release-team.md#release-commands-cheat-sheet) for example commands. | |||
|
|||
[k-announce-list]: https://groups.google.com/forum/#!forum/kubernetes-announce | |||
[k-dev-list]: https://groups.google.com/forum/#!forum/kubernetes-dev | |||
[k-dev-list]: https://groups.google.com/a/kubernetes.io/group/dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here as well
@@ -155,7 +155,7 @@ Send a Slack message to those that you select, e.g: | |||
You'll then want to join these mailing lists if you haven't already: | |||
>- https://groups.google.com/forum/#!forum/kubernetes-sig-release | |||
>- https://groups.google.com/forum/#!forum/kubernetes-sig-docs | |||
>- https://groups.google.com/forum/#!forum/kubernetes-dev | |||
>- https://groups.google.com/a/kubernetes.io/group/dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more :)
Signed-off-by: Carlos Santana <csantana23@gmail.com>
Thanks for the review @cpanato 🙏 I addressed your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, csantanapr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
Is better to have direct link to the new location of mailing list for dev@kubernetes.io
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This was s recent change, the mailing list change location
/assign @AuraSinis