Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feeds directory with OWNERS file under tooling sub-project #38

Closed
PushkarJ opened this issue Mar 1, 2022 · 7 comments
Closed

Add feeds directory with OWNERS file under tooling sub-project #38

PushkarJ opened this issue Mar 1, 2022 · 7 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/security Categorizes an issue or PR as relevant to SIG Security.

Comments

@PushkarJ
Copy link
Member

PushkarJ commented Mar 1, 2022

Related to kubernetes/enhancements#3203

  1. We need a directory under which the JSON blob exists: k/sig-security/sig-security-tooling/feeds/official-cve-feed.json
  2. Create an OWNERS file
    made of aliases.
  • The OWNERS file can include SRC alias security-response-committee and
  • A new alias for sig-security-tooling-leads

Note: sig-security-tooling-leads alias will allow manual modification and rotation for members. It will need to be added here: https://github.com/kubernetes/sig-security/blob/main/OWNERS_ALIASES. For now add @nehaLohia27 and @PushkarJ under this alias.

/help-wanted
/good-first-issue
/sig security

@k8s-ci-robot
Copy link
Contributor

@PushkarJ:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Related to kubernetes/enhancements#3203

  1. We need a directory under which the JSON blob exists: k/sig-security/sig-security-tooling/feeds/official-cve-feed.json
  2. Create an OWNERS file
    made of aliases.
  • The OWNERS file can include SRC alias security-response-committee and
  • A new alias for sig-security-tooling-leads

Note: sig-security-tooling-leads alias will allow manual modification and rotation for members. It will need to be added here: https://github.com/kubernetes/sig-security/blob/main/OWNERS_ALIASES. For now add @nehaLohia27 and @PushkarJ under this alias.

/help-wanted
/good-first-issue
/sig security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 1, 2022
@chetak123
Copy link
Member

/assign @chetak123

@PushkarJ
Copy link
Member Author

PushkarJ commented Mar 3, 2022

@chetak123 thanks for assigning this. Currently we are discussing an alternative plan which may not need work on this issue here. So please hold off work on this, until we have consensus on approach

@chetak123
Copy link
Member

OK sure

@chetak123
Copy link
Member

Hey @PushkarJ I went through issue 3295 which says we don't require any robot account or fork, And I just wanted to confirm if this issue is still needed or not ?
Thanks.

@PushkarJ
Copy link
Member Author

PushkarJ commented Jun 1, 2022

@chetak123 Good catch. We do not need it for now. If things change in future I will re-open

/close

@k8s-ci-robot
Copy link
Contributor

@PushkarJ: Closing this issue.

In response to this:

@chetak123 Good catch. We do not need it for now. If things change in future I will re-open

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/security Categorizes an issue or PR as relevant to SIG Security.
Projects
None yet
Development

No branches or pull requests

3 participants