Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we want to handle Tekton versioning? #13948

Closed
bobcatfish opened this issue Aug 16, 2019 · 19 comments
Closed

How do we want to handle Tekton versioning? #13948

bobcatfish opened this issue Aug 16, 2019 · 19 comments
Assignees
Labels
area/prow/knative-build Issues or PRs related to prow's knative-build controller component area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bobcatfish
Copy link
Contributor

What would you like to be added:

I'd like to figure out a process around keeping versions of Prow + Tekton Pipelines in sync. Some ideas:

  • Update Prow's version of Tekton Pipelines with each release (happy to help with that!)
  • Change Prow's usage of Tekton Pipelines so it is less tied to the version (e.g. Prow could use just raw json data so it doesn't need to know about the structure of the PipelineRun?)

Why is this needed:

In the context of tektoncd/pipeline#922 (and thanks to tektoncd/pipeline#1187 !) I was able to setup Prow + Tekton Pipelines, however one big issue I encountered was that the version of Tekton being vendored in for Prow is older (I think it's 0.2.0 but it also works up to 0.3.1 - specifically the trigger field was removed but in the version used by Prow it both has to be present and has to be set to manual (there might be a better way around this tho!).

We'd like to be able to use more recent versions of Tekton (if not HEAD) and trigger via Prow.

@bobcatfish bobcatfish added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 16, 2019
@vdemeester
Copy link

@bobcatfish see #13719 (should bump to 0.6.0 🙏 )

bobcatfish added a commit to bobcatfish/plumbing that referenced this issue Aug 19, 2019
A step toward tektoncd/pipeline#922 !

This commit adds configuration and supporting docs to get Prow to
execute a simple Pipeline on every pull request to the plumbing repo.

I am also working on docs in the Prow repo
(for kubernetes/test-infra#13874 and
tektoncd/pipeline#1187) to explain how
one could put this all together from scratch.

One important caveat is that we were previously using the Tekton
installation in this cluster to do manual releases, and we were keeping
our release configuration up to date with the latest version of Tekton
Pipelines. Because of kubernetes/test-infra#13948
the newest version we can use with Prow is v0.3.1 so we need to keep our
release configs in sync with this for now ( attn folks doing releases
@vdemeester @a-roberts @mnuttall - the next thing I want to do is add
release automation via Prow so hopefully this won't impact you for
long!)

Note I have already manually applied this configuration to the cluster 🙏
tekton-robot pushed a commit to tektoncd/plumbing that referenced this issue Aug 20, 2019
A step toward tektoncd/pipeline#922 !

This commit adds configuration and supporting docs to get Prow to
execute a simple Pipeline on every pull request to the plumbing repo.

I am also working on docs in the Prow repo
(for kubernetes/test-infra#13874 and
tektoncd/pipeline#1187) to explain how
one could put this all together from scratch.

One important caveat is that we were previously using the Tekton
installation in this cluster to do manual releases, and we were keeping
our release configuration up to date with the latest version of Tekton
Pipelines. Because of kubernetes/test-infra#13948
the newest version we can use with Prow is v0.3.1 so we need to keep our
release configs in sync with this for now ( attn folks doing releases
@vdemeester @a-roberts @mnuttall - the next thing I want to do is add
release automation via Prow so hopefully this won't impact you for
long!)

Note I have already manually applied this configuration to the cluster 🙏
@BenTheElder BenTheElder added area/prow/knative-build Issues or PRs related to prow's knative-build controller component area/prow Issues or PRs related to prow labels Sep 17, 2019
@eddycharly
Copy link
Member

@bobcatfish do you have any news about making prow + tekton with a higher version than 0.5.2 ?

@vdemeester
Copy link

@eddycharly I need to re-do #14216 👼

@eddycharly
Copy link
Member

@vdemeester 👍
if you don't have time, maybe i can help, would be happy to contribute 😄

@vdemeester
Copy link

@eddycharly happy to get help on that. There is two things to do (related to #14216)

  • Removing knative/build support in test-infra (as it's deprecated and it's what )
  • Updating tektoncd/pipeline 👼

@eddycharly
Copy link
Member

could we do that in two separate pull requests or should it be done in the same one ?
i will try to work on this asap and let you know.

@vdemeester
Copy link

@eddycharly can be in separate pull requests, I even think it is better to have 2 separate PR. Removing the knative build dependency is the first step.

@eddycharly
Copy link
Member

@vdemeester are there instructions to build the projects in the repository ?
i started changing things, trying to figure out how to build now...

@eddycharly
Copy link
Member

never used bazel before... trying bazel test //... 🤞

@eddycharly
Copy link
Member

bazel build //prow/... found the docs...

is it supposed to build on mac ?

ERROR: /private/var/tmp/_bazel_charlesbreteche/42dc72a11735a84e3aad14550c4ca981/external/org_golang_google_grpc/internal/syscall/BUILD.bazel:3:1: GoCompilePkg external/org_golang_google_grpc/internal/syscall/linux_amd64_
pure_stripped/go_default_library%/google.golang.org/grpc/internal/syscall.a failed (Exit 1) builder failed: error executing command bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src external/org_golang_google_grpc/internal/syscall/syscall_linux.go -src ... (remaining 19 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
compilepkg: missing strict dependencies:
        /private/var/tmp/_bazel_charlesbreteche/42dc72a11735a84e3aad14550c4ca981/sandbox/darwin-sandbox/5921/execroot/io_k8s_test_infra/external/org_golang_google_grpc/internal/syscall/syscall_linux.go: import of "golang
.org/x/sys/unix"

@eddycharly
Copy link
Member

making progress : bazel build --platforms=@io_bazel_rules_go//go/toolchain:linux_amd64 //prow/... works fine !

@bobcatfish
Copy link
Contributor Author

/assign eddycharly
🙏 ❤️

@bobcatfish bobcatfish removed their assignment Oct 30, 2019
@eddycharly
Copy link
Member

eddycharly commented Nov 1, 2019

@vdemeester First step done in #15022
Now let's update tekton pipeline ;)

@eddycharly
Copy link
Member

Here we go #15072

@vdemeester
Copy link

@eddycharly Thanks 😻

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 3, 2020
@fejta fejta removed their assignment Mar 27, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow/knative-build Issues or PRs related to prow's knative-build controller component area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants