-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tide status does not inform about pending jobs #7449
Comments
/assign |
Still an issue. |
Link? Where? How? |
I haven't seen it work anywhere. Example: openshift/origin#19288 |
Hrm, the jobs are failed and not pending. Maybe a separate issue? |
Hmm, @cjwagner in that linked case, we were on old |
@Kargakis see
|
The issue is that we would only tell you about jobs if you are LGTM+Approved and in that case you're in the pool. Issue is #7279 |
/close |
Btw, do we know what's the size limit for the status description?
…On Tue, Apr 10, 2018 at 7:43 PM, Steve Kuznetsov ***@***.***> wrote:
@Kargakis <https://github.com/kargakis> see
{"client":"github","component":"tide","level":"info","msg":"CreateStatus(openshift, openshift-ansible, 1d6173922d5e68b1fec7734d24ecd24b4eed7830, {pending https://deck-ci.svc.ci.openshift.org/tide.html Not mergeable. Job ci/openshift-jenkins/gcp has not succeeded. tide})","time":"2018-04-10T17:39:56Z"}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7449 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADuFfzRpR7L2hzjrrHAxcZ3iXU51AFoxks5tnO8wgaJpZM4S-cA7>
.
|
We're just estimating the size limit. It seems to be somewhere around 80 characters, but it could be display dependent. |
When a PR has all the labels set but waits on one or more pending jobs, tide just reports that the PR is in the merge pool. It should pick a pending job and state that it's waiting for it to finish.
/area prow
/kind bug
@cjwagner @stevekuznetsov
The text was updated successfully, but these errors were encountered: