Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tide status does not inform about pending jobs #7449

Closed
0xmichalis opened this issue Mar 28, 2018 · 11 comments
Closed

tide status does not inform about pending jobs #7449

0xmichalis opened this issue Mar 28, 2018 · 11 comments
Assignees
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.

Comments

@0xmichalis
Copy link
Contributor

When a PR has all the labels set but waits on one or more pending jobs, tide just reports that the PR is in the merge pool. It should pick a pending job and state that it's waiting for it to finish.

/area prow
/kind bug

@cjwagner @stevekuznetsov

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. labels Mar 28, 2018
@stevekuznetsov
Copy link
Contributor

/assign

@0xmichalis
Copy link
Contributor Author

Still an issue.

@0xmichalis 0xmichalis reopened this Apr 10, 2018
@stevekuznetsov
Copy link
Contributor

Link? Where? How?

@0xmichalis
Copy link
Contributor Author

I haven't seen it work anywhere.

Example: openshift/origin#19288

@0xmichalis
Copy link
Contributor Author

Hrm, the jobs are failed and not pending. Maybe a separate issue?

@stevekuznetsov
Copy link
Contributor

Hmm, @cjwagner in that linked case, we were on old tide and upgraded to new tide. We should have updated the statuses since the wanted state (pending) doesn't match the actual state (successful). So the bug is in update, not this bug specifically.

@stevekuznetsov
Copy link
Contributor

@Kargakis see

{"client":"github","component":"tide","level":"info","msg":"CreateStatus(openshift, openshift-ansible, 1d6173922d5e68b1fec7734d24ecd24b4eed7830, {pending https://deck-ci.svc.ci.openshift.org/tide.html Not mergeable. Job ci/openshift-jenkins/gcp has not succeeded. tide})","time":"2018-04-10T17:39:56Z"}

@stevekuznetsov
Copy link
Contributor

The issue is that we would only tell you about jobs if you are LGTM+Approved and in that case you're in the pool. Issue is #7279

@stevekuznetsov
Copy link
Contributor

/close

@0xmichalis
Copy link
Contributor Author

0xmichalis commented Apr 10, 2018 via email

@cjwagner
Copy link
Member

Btw, do we know what's the size limit for the status description?

We're just estimating the size limit. It seems to be somewhere around 80 characters, but it could be display dependent.
The spaced used for the description text is shared with the context name and state so less space is available if the status is pending. Hovering with the cursor shows the full description text even if the description is truncated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants