-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow retester to work with optional contexts #8008
Comments
@sdodson fyi |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Maybe its first comment can have /skip? |
Note that /skip works only with contexts owned by prow. |
Sure, but I don't know if we need to solve "PR is lgtm + approve but not merging and failing a non-prow presubmit while using fejta-bot", OTOH: "PR is lgtm + approve but not merging while failing a non-blocking prow presubmit while using fejta-bot" seems simple to fix. |
Or: cutting down fejta-bot spam that isn't due to important failures seems like a good idea, but fejta-bot will also spam for any context not passing that is blocking besides ones that aren't prow currently (and non-blockng prow). I'm not sure if we need to immediately handle all of these. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Soon tide will be able to handle optional github contexts. We should also find a solution for having the commenter ignore optional contexts too.
@stevekuznetsov @fejta @cjwagner
/area prow
/kind feature
The text was updated successfully, but these errors were encountered: