Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup prow jobs for Kubeflow GCP blueprints. #17928

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Setup prow jobs for Kubeflow GCP blueprints. #17928

merged 1 commit into from
Jun 12, 2020

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jun 12, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 12, 2020
@jlewi
Copy link
Contributor Author

jlewi commented Jun 12, 2020

/assign @aronchick

@aronchick Can you LGTM this? It needs to be another member of the Kubernetes org?

aronchick
aronchick approved these changes Jun 12, 2020
View reviewed changes
Copy link

@aronchick aronchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aronchick, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aronchick
Copy link

LGTM'd a bunch of yaml, achievement unlocked

@k8s-ci-robot k8s-ci-robot merged commit 5a71a61 into kubernetes:master Jun 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 12, 2020
@k8s-ci-robot
Copy link
Contributor

@jlewi: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubeflow-periodics.yaml using file config/jobs/kubeflow/kubeflow-periodics.yaml
  • key kubeflow-postsubmits.yaml using file config/jobs/kubeflow/kubeflow-postsubmits.yaml
  • key kubeflow-presubmits.yaml using file config/jobs/kubeflow/kubeflow-presubmits.yaml

In response to this:

Related to GoogleCloudPlatform/kubeflow-distribution#42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aronchick aronchick aronchick approved these changes

@clarketm clarketm Awaiting requested review from clarketm

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@aronchick aronchick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@jlewi @k8s-ci-robot @aronchick