Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pull-kubernetes-e2e-gce to k8s-infra-prow-build #18916

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Migrate pull-kubernetes-e2e-gce to k8s-infra-prow-build #18916

merged 1 commit into from
Aug 19, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 19, 2020

Even though 1.19 and the main branch variants are no longer
merge blocking, let's go ahead and move them all at once

Part of #18852

@spiffxp
Migrate pull-kubernetes-e2e-gce to k8s-infra-prow-build
6416718 
Even though 1.19 and the main branch variants are no longer
merge blocking, let's go ahead and move them all at once
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 19, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 19, 2020

/cc @BenTheElder

@spiffxp
Copy link
Member Author

spiffxp commented Aug 19, 2020

/cc @hasheddan

@spiffxp
Copy link
Member Author

spiffxp commented Aug 19, 2020

FYI @kubernetes/ci-signal

hasheddan
hasheddan approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3df0356 into kubernetes:master Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml

In response to this:

Even though 1.19 and the main branch variants are no longer
merge blocking, let's go ahead and move them all at once

Part of #18852

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the migrate-pull-e2e-gce-to-k8s-infra-prow-build branch August 26, 2020 22:20
This was referenced Sep 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@justaugustus justaugustus Awaiting requested review from justaugustus

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan