Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network-proxy presubmit optional #19033

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 28, 2020

The job is solidly failing and blocking merges (e.g. kubernetes/kubernetes#93095)

It looks like work on the job is in progress (kubernetes/kubernetes#94127), but it should not be blocking.

cc @BenTheElder
cc @bartsmykla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 28, 2020
@bartsmykla
Copy link

@spiffxp could you help, as I don't have enough permissions?

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2020
@spiffxp
Copy link
Member

spiffxp commented Aug 28, 2020

@bartsmykla are you going to have time to get to #18853 (comment) ?

@BenTheElder
Copy link
Member

I feel like we should have an allowlist config test of blocking kubernetes presubmits to prevent this sort of surprise.

@k8s-ci-robot k8s-ci-robot merged commit 2e51e45 into kubernetes:master Aug 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Aug 28, 2020
@k8s-ci-robot
Copy link
Contributor

@liggitt: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-api-machinery-config.yaml using file config/jobs/kubernetes/sig-api-machinery/sig-api-machinery-config.yaml

In response to this:

The job is solidly failing and blocking merges (e.g. kubernetes/kubernetes#93095)

It looks like work on the job is in progress (kubernetes/kubernetes#94127), but it should not be blocking.

cc @BenTheElder
cc @bartsmykla

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bartsmykla
Copy link

@spiffxp apologies, missed that comment. On it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants