-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make network-proxy presubmit optional #19033
Make network-proxy presubmit optional #19033
Conversation
@spiffxp could you help, as I don't have enough permissions? |
6783077
to
49fd264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bartsmykla are you going to have time to get to #18853 (comment) ? |
I feel like we should have an allowlist config test of blocking kubernetes presubmits to prevent this sort of surprise. |
@liggitt: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spiffxp apologies, missed that comment. On it |
The job is solidly failing and blocking merges (e.g. kubernetes/kubernetes#93095)
It looks like work on the job is in progress (kubernetes/kubernetes#94127), but it should not be blocking.
cc @BenTheElder
cc @bartsmykla