-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secrets-store-csi-driver: gcp use workload identity instead of secret #22944
Conversation
842e095
to
543eab1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Do you plan on removing test-infra/config/prow/cluster/build_kubernetes-external-secrets_customresource.yaml Line 20 in c0c1a41
|
Yeah, I want to keep that around and remove in a separate PR in case things go wildly wrong |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: e-blackwelder, tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tam7t: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This secret is no longer needed by the secrets-store-csi-driver-e2e-gcp test jobs as kubernetes#22944 migrated the job to use workload identity instead.
Alternative to ExternalSecret syncing, using workload identity for the secrets-store-csi-driver gcp integration tests:
Requires:
I've verified that the GCP provider process in the test cases currently runs as the user
serviceAccount:k8s-prow-builds.svc.id.goog[test-pods/default]
. Switching the pod to a different SA and granting:serviceAccount:k8s-prow-builds.svc.id.goog[test-pods/secrets-store-csi-driver-gcp]
permission to act ask8s-csi-test@secretmanager-csi-build.iam.gserviceaccount.com
will allow the test cases to use workload identity instead of exported SA + sync'd secret.