Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets-store-csi-driver: gcp use workload identity instead of secret #22944

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Jul 19, 2021

Alternative to ExternalSecret syncing, using workload identity for the secrets-store-csi-driver gcp integration tests:

Requires:

I've verified that the GCP provider process in the test cases currently runs as the user serviceAccount:k8s-prow-builds.svc.id.goog[test-pods/default]. Switching the pod to a different SA and granting:

serviceAccount:k8s-prow-builds.svc.id.goog[test-pods/secrets-store-csi-driver-gcp] permission to act as k8s-csi-test@secretmanager-csi-build.iam.gserviceaccount.com will allow the test cases to use workload identity instead of exported SA + sync'd secret.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 19, 2021
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@aramase
Copy link
Member

aramase commented Jul 20, 2021

Do you plan on removing

in a followup PR?

@tam7t
Copy link
Contributor Author

tam7t commented Jul 20, 2021

Do you plan on removing

in a followup PR?

Yeah, I want to keep that around and remove in a separate PR in case things go wildly wrong

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: e-blackwelder, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit a9d418c into kubernetes:master Jul 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

@tam7t: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key secrets-store-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml
  • key secrets-store-csi-driver-presets.yaml using file config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-presets.yaml

In response to this:

Alternative to ExternalSecret syncing, using workload identity for the secrets-store-csi-driver gcp integration tests:

Requires:

I've verified that the GCP provider process in the test cases currently runs as the user serviceAccount:k8s-prow-builds.svc.id.goog[test-pods/default]. Switching the pod to a different SA and granting:

serviceAccount:k8s-prow-builds.svc.id.goog[test-pods/secrets-store-csi-driver-gcp] permission to act as k8s-csi-test@secretmanager-csi-build.iam.gserviceaccount.com will allow the test cases to use workload identity instead of exported SA + sync'd secret.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tam7t tam7t deleted the tam7t/gcp-workload-id branch July 26, 2021 20:06
tam7t added a commit to tam7t/test-infra that referenced this pull request Jul 27, 2021
This secret is no longer needed by the secrets-store-csi-driver-e2e-gcp
test jobs as
kubernetes#22944 migrated the job
to use workload identity instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants