Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: update CAPZ release branch to release-1.1 #25326

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Azure: update CAPZ release branch to release-1.1 #25326

merged 1 commit into from
Feb 17, 2022

Conversation

CecileRobertMichon
Copy link
Member

Now that kubernetes-sigs/cluster-api-provider-azure#2103 has merged, bumping the version of CAPZ to release-1.1 for in tree cloud provider tests.

This won't fix conformance @ main quite yet since we also need kubernetes-sigs/cluster-api-provider-azure#2098 but will allow us to fix tests on main with an easier cherry-pick to 1.1.

/assign @jsturtevant @jackfrancis

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 17, 2022
@jackfrancis
Copy link
Contributor

@CecileRobertMichon can we scaffold a rubber duck k/k PR to rapidly test against once we merge this PR? (Happy to do that)

@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2022
jackfrancis
jackfrancis approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@CecileRobertMichon
Copy link
Member Author

CecileRobertMichon commented Feb 17, 2022 •
edited
Loading

can we scaffold a rubber duck k/k PR to rapidly test against once we merge this PR? (Happy to do that)

@jackfrancis k/k PR tests will still fail after this merges (they are failing right now) see PR description

This won't fix conformance @ main quite yet since we also need kubernetes-sigs/cluster-api-provider-azure#2098 but will allow us to fix tests on main with an easier cherry-pick to 1.1.

we could test to make sure it fails with the expected error, but we should expect a pass just yet

@CecileRobertMichon
Copy link
Member Author

/approve

@CecileRobertMichon
Copy link
Member Author

/assign @chewong @andyzhangx

chewong
chewong approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, chewong, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit aad4268 into kubernetes:master Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-1.20.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.20.yaml
  • key release-1.21.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.21.yaml
  • key release-1.22.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.22.yaml
  • key release-1.23.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.23.yaml
  • key release-master.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml

In response to this:

Now that kubernetes-sigs/cluster-api-provider-azure#2103 has merged, bumping the version of CAPZ to release-1.1 for in tree cloud provider tests.

This won't fix conformance @ main quite yet since we also need kubernetes-sigs/cluster-api-provider-azure#2098 but will allow us to fix tests on main with an easier cherry-pick to 1.1.

/assign @jsturtevant @jackfrancis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewong chewong chewong approved these changes

@jackfrancis jackfrancis jackfrancis approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@jsturtevant jsturtevant

@jackfrancis jackfrancis

@andyzhangx andyzhangx

@chewong chewong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
6 participants
@CecileRobertMichon @jackfrancis @jsturtevant @k8s-ci-robot @chewong @andyzhangx