Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to fix k8s-cve-feed prow job failures #26990

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Updates to fix k8s-cve-feed prow job failures #26990

merged 1 commit into from
Aug 2, 2022

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Aug 1, 2022 •
edited
Loading

🤞🏼🤞🏼🤞🏼

  • Switched image that has python and gsutil installed
  • Divided up the command line to be executed into shell
    args
  • Made k/sig-security the default working directory

/sig security testing k8s-infra

Previous attempts to make it work: #26896 and #26988

Inspired from #26928

/cc @palnabarun @nehaLohia27 @ameukam

@PushkarJ
Updates to fix k8s-cve-feed prow job failures
2e85c70 
- Switched image that has python and gsutil installed
- Divided up the command line to be executed into shell
args
- Made k/sig-security the default working directory
@k8s-ci-robot k8s-ci-robot added sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2022
@PushkarJ PushkarJ mentioned this pull request Aug 1, 2022
Merged
@PushkarJ
Copy link
Member Author

PushkarJ commented Aug 1, 2022

/hold

(For kubernetes/sig-security#57)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@nehaLohia27
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@ameukam
Copy link
Member

ameukam commented Aug 2, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, nehaLohia27, PushkarJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7189143 into kubernetes:master Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

@PushkarJ: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-security-trusted.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-security-trusted.yaml

In response to this:

🤞🏼🤞🏼🤞🏼

  • Switched image that has python and gsutil installed
  • Divided up the command line to be executed into shell
    args
  • Made k/sig-security the default working directory

/sig security testing k8s-infra

Previous attempts to make it work: #26896 and #26988

Inspired from #26928

/cc @palnabarun @nehaLohia27 @ameukam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PushkarJ PushkarJ mentioned this pull request Aug 2, 2022
Open
14 tasks
@PushkarJ PushkarJ mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehaLohia27 nehaLohia27 nehaLohia27 approved these changes

@ameukam ameukam Awaiting requested review from ameukam

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@nehaLohia27 nehaLohia27

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@PushkarJ @nehaLohia27 @ameukam @k8s-ci-robot