Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change e2e ingress job #28095

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Change e2e ingress job #28095

merged 1 commit into from
Mar 3, 2023

Conversation

code-elinka
Copy link
Contributor

@code-elinka code-elinka commented Nov 23, 2022 •
edited
Loading

Use both arm64 & amd64 archs to build e2e-test images for k8s ingress job.

This should be merged after update in e2e-test Dockerfile (kubernetes/ingress-gce#1863) change.

Signed-off-by: Elina Akhmanova elinka@google.com

@code-elinka
Change e2e ingress job
70affe7 
Use both arm64 & amd64 archs to build
e2e-test images for k8s ingress job.

Signed-off-by: Elina Akhmanova <elinka@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @code-elinka!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @code-elinka. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 23, 2022
@code-elinka
Copy link
Contributor Author

/assign @aojea

@code-elinka code-elinka mentioned this pull request Nov 23, 2022
Closed
@aojea
Copy link
Member

aojea commented Nov 23, 2022

/ok-to-test
/hold

This should be merged after update in e2e-test Dockerfile (kubernetes/ingress-gce#1863) change.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2022
@code-elinka
Copy link
Contributor Author

/retest

@cadmuxe
Copy link
Member

cadmuxe commented Feb 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cadmuxe, code-elinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@aojea
Copy link
Member

aojea commented Feb 15, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023
@aojea aojea mentioned this pull request Feb 15, 2023
Merged
@code-elinka
Copy link
Contributor Author

/ok-to-test /hold

This should be merged after update in e2e-test Dockerfile (kubernetes/ingress-gce#1863) change.

@aojea Do you think we can merge this PR?

@aojea
Copy link
Member

aojea commented Mar 3, 2023

/ok-to-test /hold

This should be merged after update in e2e-test Dockerfile (kubernetes/ingress-gce#1863) change.

@aojea Do you think we can merge this PR?

/hold cancel
/lgtm

+1

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit fce2fb2 into kubernetes:master Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

@code-elinka: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml

In response to this:

Use both arm64 & amd64 archs to build e2e-test images for k8s ingress job.

This should be merged after update in e2e-test Dockerfile (kubernetes/ingress-gce#1863) change.

Signed-off-by: Elina Akhmanova elinka@google.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@code-elinka code-elinka deleted the change-e2e-test branch March 6, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@cadmuxe cadmuxe Awaiting requested review from cadmuxe

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@code-elinka @k8s-ci-robot @aojea @cadmuxe @k8s-triage-robot