-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (kubebuilder) new config image job for kube-rbac-proxy image #29351
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
camilamacedo86:kubebuilder-proxy-image
May 10, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
postsubmits: | ||
kubernetes-sigs/kubebuilder: | ||
|
||
- name: post-kube-rbac-proxy-push-images | ||
cluster: k8s-infra-prow-build-trusted | ||
annotations: | ||
testgrid-dashboards: sig-api-machinery-kubebuilder, sig-k8s-infra-gcb | ||
decorate: true | ||
run_if_changed: "^kube-rbac-proxy-releases/" | ||
branches: | ||
- ^kube-rbac-proxy-releases$ | ||
spec: | ||
serviceAccountName: gcb-builder | ||
containers: | ||
- image: gcr.io/k8s-staging-test-infra/image-builder:v20230111-cd1b3caf9c | ||
command: | ||
- /run.sh | ||
args: | ||
- --project=k8s-staging-kubebuilder | ||
- --scratch-bucket=gs://k8s-staging-kubebuilder-gcb | ||
- --env-passthrough=PULL_BASE_REF | ||
- --with-git-dir | ||
- --gcb-config=build/cloudbuild_kube-rbac-proxy.yaml | ||
- . | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: instead of using --gcb-config here, probably you want to create a new directory in https://github.com/kubernetes-sigs/kubebuilder/tree/kube-rbac-proxy-releases with a proper cloudbuild, and point to that directory
eg.:
And add a new cloudbuild.yaml inside this directory (see https://github.com/kubernetes/ingress-nginx/blob/main/cloudbuild.yaml). In this case if you want to test different combinations of cloudbuild.yaml later you won't need to change the one that is already working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I see it here: https://github.com/kubernetes-sigs/kubebuilder/pull/3362/files
let me continue the discussion there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I understand that is right. Am I right?
See that I am doing like : https://github.com/kubernetes/test-infra/blob/3b85f96f30d6f1ce48639ccbdbde396cc3c8b183/config/jobs/image-pushing/k8s-staging-kustomize.yaml#LL28C1-L38C18
Note that for Kubebuilder, we do not use docker to build the image.
So, I understand that when we merge this one, we should see a new trigger created in the GCP, such as we have now:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this suggestion, but not blocking
put a hold in case