use standard image pushing job #29371
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @code-elinka |
k8s-ci-robot
added
area/config
remove the old postubmit job that is not working and use the standardized job to push images using cloudbuild Change-Id: I752e120c662453eecc2e38778fb6c83668ccbc67
aojea
force-pushed
the
ingress-gce-images
branch
from
f2f8761 to
2dddd85
Compare
| @@ -0,0 +1,27 @@ | |||
| postsubmits: | |||
|
|
|||
There was a problem hiding this comment.
nit: do we need this line?
There was a problem hiding this comment.
it can go both ways, is an style thing at this point
| - --project=k8s-ingress-image-push | ||
| - --scratch-bucket=gs://k8s-ingress-image-push-gcb | ||
| - --env-passthrough=PULL_BASE_REF | ||
| - --with-git-dir |
There was a problem hiding this comment.
do we need git log/tag history or is it just in case it will be needed?
k8s-ci-robot
added
the
lgtm
| - . | ||
| env: | ||
| - name: LOG_TO_STDOUT | ||
| value: "y" |
There was a problem hiding this comment.
We don't add REGISTRY just because it's a part of building yaml in ingress-gce repo?
There was a problem hiding this comment.
right, is not that we are going to push to a different registry, so I prefer to keep all the config in the repo
|
I need approval here |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, aojea, code-elinka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@aojea: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
remove the old postubmit job that is not working and use the standardized job to push images using cloudbuild
https://github.com/kubernetes/test-infra/tree/master/config/jobs/image-pushing#image-pushing-jobs