Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kubernetes/{org,enhancements,community} jobs to eks-prow-build-cluster #29737

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Migrate kubernetes/{org,enhancements,community} jobs to eks-prow-build-cluster #29737

merged 3 commits into from
Jun 15, 2023

Conversation

palnabarun
Copy link
Member

  • jobs: migrate kubernetes/org jobs to eks cluster
  • jobs: migrate kubernetes/enhancements jobs to eks cluster
  • jobs: migrate kubernetes/community jobs to eks cluster

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/enhancements Issues or PRs related to the Enhancements subproject area/jobs sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 9, 2023
@palnabarun
Copy link
Member Author

/assign @nikhita
(for k/org)

/assign @jeremyrickard
(for k/enhancements)

@rjsadow
Copy link
Contributor

rjsadow commented Jun 9, 2023

ref #29722

@rjsadow rjsadow mentioned this pull request Jun 9, 2023
Closed
54 tasks
@ameukam
Copy link
Member

ameukam commented Jun 13, 2023

@palnabarun requests and limits are required for pull-community-tempelis-check.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@palnabarun
Copy link
Member Author

@ameukam is there a guideline for how much CPU/mem usage limits/requests that should be put for a job?

Ideally, the value should closely correlate to existing memory usage by the jobs. Is there a dashboard to show usage metrics?

@rjsadow
Copy link
Contributor

rjsadow commented Jun 15, 2023

It's hard to say as each job is different and we don't have reliable monitoring on the google cluster jobs. I would recommend starting with 2 cpu and 4GB memory. We can monitor their resource usage through Kabana (eks cluster) (https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?from=now-24h&to=now) after they're merged and fine tune the capacity requirements later.

@ameukam
Copy link
Member

ameukam commented Jun 15, 2023 •
edited
Loading

It's hard to say as each job is different and we don't have reliable monitoring on the google cluster jobs. I would recommend starting with 2 cpu and 4GB memory. We can monitor their resource usage through Kabana (eks cluster) (https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?from=now-24h&to=now) after they're merged and fine tune the capacity requirements later.

@palnabarun we currently don't have a baseline all the prowjobs we have. what Ricky said is what we are recommending right now.

@palnabarun
Copy link
Member Author

Thanks @rjsadow @ameukam! I will update the jobs.

@palnabarun palnabarun force-pushed the migrate-org-enhancements-community-jobs branch from e52237e to 1ff1432 Compare June 15, 2023 12:42
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2023
@palnabarun
jobs: migrate kubernetes/org jobs to eks cluster
ae8bccd 
also, add cpu/mem limits and requests to the jobs

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
jobs: migrate kubernetes/enhancements jobs to eks cluster
77ecf46 
also, add cpu/mem limits and requests to the jobs

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
jobs: migrate kubernetes/community jobs to eks cluster
e0eef99 
also, add cpu/mem limits and requests to the jobs

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun palnabarun force-pushed the migrate-org-enhancements-community-jobs branch from 1ff1432 to e0eef99 Compare June 15, 2023 12:45
@ameukam
Copy link
Member

ameukam commented Jun 15, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 24709a9 into kubernetes:master Jun 15, 2023
@k8s-ci-robot
Copy link
Contributor

@palnabarun: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key community-presubmit.yaml using file config/jobs/kubernetes/community/community-presubmit.yaml
  • key enhancements-presubmit.yaml using file config/jobs/kubernetes/enhancements/enhancements-presubmit.yaml
  • key kubernetes-org-jobs.yaml using file config/jobs/kubernetes/org/kubernetes-org-jobs.yaml

In response to this:

  • jobs: migrate kubernetes/org jobs to eks cluster
  • jobs: migrate kubernetes/enhancements jobs to eks cluster
  • jobs: migrate kubernetes/community jobs to eks cluster

/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@ameukam ameukam

@nikhita nikhita

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/enhancements Issues or PRs related to the Enhancements subproject area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@palnabarun @rjsadow @ameukam @k8s-ci-robot @nikhita @jeremyrickard