Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job: migrate ci-kubernetes-e2e-gce-iscsi-serial job to community cluster #31803

Merged
merged 1 commit into from
Feb 5, 2024
Merged

job: migrate ci-kubernetes-e2e-gce-iscsi-serial job to community cluster #31803

merged 1 commit into from
Feb 5, 2024

Conversation

alessandrocapanna
Copy link
Contributor

This PR transitions the ci-kubernetes-e2e-gce-iscsi-serial job to eks-prow-build-cluster

@ameukam

Part of #31789

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 1, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alessandrocapanna (3fc58ba)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @alessandrocapanna!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @alessandrocapanna. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2024
@alessandrocapanna
Copy link
Contributor Author

@ameukam i changed cluster as you said

@ameukam
Copy link
Member

ameukam commented Feb 2, 2024

@alessandrocapanna Can you address the Easy CLA issue ? See: https://github.com/kubernetes/community/blob/master/CLA.md.

@alessandrocapanna alessandrocapanna force-pushed the migrate-to-community-clusters branch 3 times, most recently from 7499a33 to ef1a4af Compare February 2, 2024 14:58
@alessandrocapanna
Copy link
Contributor Author

/check-cla

@alessandrocapanna alessandrocapanna force-pushed the migrate-to-community-clusters branch 2 times, most recently from a6db8f4 to 96c1164 Compare February 2, 2024 16:41
@alessandrocapanna
Migrate ci-kubernetes-e2e-gce-iscsi-serial job into community cluster
3fc58ba 
chore: adjust resource requests and limits to ci-kubernetes-e2e-gce-iscsi-serial

fix: ci-kubernetes-e2e-gce-iscsi-serial now use the right cluster and fix Easy CLA

Migrate ci-kubernetes-e2e-gce-iscsi-serial job into community cluster

chore: adjust resource requests and limits to ci-kubernetes-e2e-gce-iscsi-serial

fix: ci-kubernetes-e2e-gce-iscsi-serial now use the right cluster and fix Easy CLA
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 2, 2024
@alessandrocapanna alessandrocapanna changed the title job: migrate ci-kubernetes-e2e-gce-iscsi-serial job to eks cluster job: migrate ci-kubernetes-e2e-gce-iscsi-serial job to community cluster Feb 2, 2024
@alessandrocapanna
Copy link
Contributor Author

@ameukam i fixed Easy CLA issue

@ameukam
Copy link
Member

ameukam commented Feb 2, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2024
@rjsadow
Copy link
Contributor

rjsadow commented Feb 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2024
@ameukam
Copy link
Member

ameukam commented Feb 5, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alessandrocapanna, ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8539fd1 into kubernetes:master Feb 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@alessandrocapanna: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-storage-gce-config.yaml using file config/jobs/kubernetes/sig-storage/sig-storage-gce-config.yaml

In response to this:

This PR transitions the ci-kubernetes-e2e-gce-iscsi-serial job to eks-prow-build-cluster

@ameukam

Part of #31789

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessandrocapanna @k8s-ci-robot @ameukam @rjsadow