Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI-O: add pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e test job #33071

Merged
merged 1 commit into from
Jul 24, 2024
Merged

CRI-O: add pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e test job #33071

merged 1 commit into from
Jul 24, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jul 23, 2024 •
edited
Loading

Adding a new job for the imagevolume alpha tests.

Requires cri-o/cri-o#8408
Will be required for kubernetes/kubernetes#126220

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2024
@saschagrunert saschagrunert mentioned this pull request Jul 23, 2024
Open
9 tasks
@saschagrunert saschagrunert force-pushed the crio-bump branch 2 times, most recently from e0ef515 to 1a406c5 Compare July 23, 2024 15:12
@saschagrunert saschagrunert changed the title WIP: CRI-O: bump cgroupv2 test versions WIP: CRI-O: add imagevolume test job Jul 23, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs labels Jul 23, 2024
@saschagrunert saschagrunert changed the title WIP: CRI-O: add imagevolume test job WIP: CRI-O: add pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e test job Jul 23, 2024
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@saschagrunert
CRI-O: add imagevolume test job
ac85ebf 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this pull request Jul 23, 2024
Merged
saschagrunert
saschagrunert commented Jul 23, 2024
View reviewed changes
jobs/e2e_node/crio/templates/generate
@@ -28,7 +28,7 @@ declare -A CONFIGURATIONS=(
["crio_cgroupsv1"]="root cgroups-v1 criu-enabled"
["crio_cgroupsv1_eventedpleg"]="root cgroups-v1 eventedpleg"
["crio_cgroupsv1_hugepages"]="root cgroups-v1 hugepages"
["crio_cgroupsv2"]="root"
["crio_cgroupsv2"]="root-v2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll swap the other tests as follow-up if everything is green.

@saschagrunert saschagrunert changed the title WIP: CRI-O: add pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e test job CRI-O: add pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e test job Jul 23, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2024
@saschagrunert
Copy link
Member Author

saschagrunert commented Jul 23, 2024 •
edited
Loading

/hold

Ready for review, I just like to hold to have control over when it merges (during my working hours).

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024
@saschagrunert
Copy link
Member Author

Asking for node approval @yujuhong @Random-Liu @dchen1107 @derekwaynecarr @sjenning @mrunalp @klueska @SergeyKanzhelev @endocrimes

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2024
SergeyKanzhelev
SergeyKanzhelev approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@saschagrunert
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit eef81de into kubernetes:master Jul 24, 2024
8 checks passed
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Adding a new job for the imagevolume alpha tests.

Requires cri-o/cri-o#8408
Will be required for kubernetes/kubernetes#126220

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert saschagrunert deleted the crio-bump branch July 24, 2024 06:45
@saschagrunert saschagrunert mentioned this pull request Jul 24, 2024
Merged
saschagrunert added a commit to saschagrunert/test-infra that referenced this pull request Jul 24, 2024
@saschagrunert
CRI-O: bump test versions
0f313ec 
As follow-up on the CRI-O bump in
kubernetes#33071,
we now update the other tests to the latest CRI-O version as well.

This also clean-up the `v2` config file suffixes.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this pull request Jul 24, 2024
Merged
@kannon92 kannon92 mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@klueska klueska Awaiting requested review from klueska

Assignees

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @haircommander @k8s-ci-robot @SergeyKanzhelev