Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ci/latest instead of latest in the kubeadm e2e job #4176

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

luxas
Copy link
Member

@luxas luxas commented Aug 24, 2017

As it will use control plane images from HEAD instead of the latest alpha version.

Fixes kubernetes/kubeadm#238
Works thanks to PR kubernetes/kubernetes#49119

/assign @krzyzacy @pipejakob @roberthbailey @ixdy

cc @kad

@luxas luxas changed the title Use ci/latest instead of latest in the kubeadm e2e job … Use ci/latest instead of latest in the kubeadm e2e job Aug 24, 2017
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2017
@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2017
@kad
Copy link
Member

kad commented Aug 24, 2017

cool

@kad
Copy link
Member

kad commented Aug 24, 2017

BTW, should it be also separate job not only for latest (master) builds but also for CI builds of e.g. release-1.7 branches ?

@krzyzacy
Copy link
Member

/lgtm

let me know if you wanna merge this

@luxas
Copy link
Member Author

luxas commented Aug 24, 2017

@krzyzacy Please do 👍

@kad That wouldn't work, as this feature didn't exist in v1.7

@krzyzacy krzyzacy merged commit b49cfe9 into kubernetes:master Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants