Convert boskos deployment to a statefulset #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
For #4571 |
foxish
reviewed
Sep 15, 2017
boskos/deployment.yaml
Outdated
| accessModes: | ||
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 1Gi | ||
| --- | ||
| # Start of Deployment | ||
| apiVersion: extensions/v1beta1 | ||
| kind: Deployment | ||
| apiVersion: apps/v1beta1 |
boskos/deployment.yaml
Outdated
| @@ -35,24 +38,24 @@ kind: PersistentVolumeClaim | |||
| metadata: | |||
| labels: | |||
| app: boskos | |||
| name: boskos-storage | |||
| name: boskos-volume-boskos-0 | |||
There was a problem hiding this comment.
We don't need this anymore because the StatefulSet controller will stamp out a PVC
msau42
force-pushed
the
convert-statefulset
branch
from
6e0af02 to
5e02981
Compare
k8s-ci-robot
added
size/M
|
Updated. The filename itself should also change but I wasn't sure if that would break any scripts. |
|
lgtm. Thanks! |
|
(deployed - looks working except that seems the cache saved inside previous pv is wiped? but seems it regenerated fine) |
|
Hm that shouldn't happen since the PV reclaim policy is retain. |
msau42
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@krzyzacy if it works for you, then go ahead and merge this when you're ready. |
|
/lgtm I'll watch the cache issue next time we redeploy. Huge thanks! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only tested creating the statefulset + volumes to make sure the names are correct and it mounts properly. But I haven't done any e2e testing to determine if there's anything else that needs to be updated.