Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge kubectl approved PRs #5720

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Conversation

apelisse
Copy link
Member

Kubectl PRs should be merged as soon as they have review approval.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 29, 2017
@krzyzacy
Copy link
Member

/assign @cjwagner

@BenTheElder
Copy link
Member

LGTM but punt to cole since there's an extra query now :-)

@cjwagner
Copy link
Member

/lgtm
🤞

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, cjwagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2017
@k8s-ci-robot k8s-ci-robot merged commit a41c306 into kubernetes:master Nov 29, 2017
@k8s-ci-robot
Copy link
Contributor

@apelisse: I updated Prow config for you!

In response to this:

Kubectl PRs should be merged as soon as they have review approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjwagner
Copy link
Member

Seems to have worked for the 1 PR in kubernetes/kubectl that matched the query: kubernetes/kubectl#149 (comment)

@apelisse
Copy link
Member Author

Yeah! Thanks @cjwagner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants